Make fullscreen video in detailed status plays in fullscreen (Partly Fix #5160) #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
abcang
reviewed
Nov 7, 2017
| @@ -65,10 +67,19 @@ export default class Status extends ImmutablePureComponent { | |||
| intl: PropTypes.object.isRequired, | |||
| }; | |||
|
|
|||
| constructor (props) { | |||
There was a problem hiding this comment.
context should also be passed as an argument.
constructor (props, context) {
super(props, context);
}Or, it is recommended to assign state without using constructor.
export default class Status extends ImmutablePureComponent {
static propTypes = {};
state = {};
componentWillMount () {}
}
nullkal
changed the title
abcang
reviewed
Nov 7, 2017
| @@ -65,10 +67,19 @@ export default class Status extends ImmutablePureComponent { | |||
| intl: PropTypes.object.isRequired, | |||
| }; | |||
|
|
|||
| constructor (props) { | |||
| super(props); | |||
| this.state = {}; | |||
There was a problem hiding this comment.
I thought it was better to set it to the initial value of fullscreen of state.
Gargron
approved these changes
Nov 7, 2017
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Dec 6, 2017
mastodon#5160) (mastodon#5611) * Make fullscreen video in detailed status plays in fullscreen (Fix mastodon#5160) * Directly assign the initial state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.