Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to block direct messages from people you don't follow #5669

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Nov 13, 2017

Fix #5326

I heard some discussion about communicating to the end-user that the message could not be delivered when it's blocked like this, however there are no such indications when notifications are blocked using any other means in NotifyService, and they are generally impossible to implement consistently between local and remote accounts and therefore undesirable. Plus since a direct message is not generally directed as much as it tags one or more people who may or may not see it...

@koboldunderlord
Copy link
Contributor

Looks like this is just a face-lift on the changes Paul and i made and doesn't address the criticism of the change - if a user initiates a direct message with someone they don't follow with the option on, there is no way to see responses from said person, unless I'm misreading your changes.

@nightpool
Copy link
Member

nightpool commented Nov 13, 2017

@Gargron I think it makes a lot of sense from a UX and product perspective to a do a Reject { Note } for DMs that get filtered due to this option, which would bring us to parity (IMO) with twitter's feature in this area.

I understand if you think that's too much complexity though

Copy link
Member

@nightpool nightpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Errors are probably not critical here

@Gargron Gargron merged commit fbef909 into master Nov 14, 2017
@Gargron Gargron deleted the feature-dm-mutuals branch November 14, 2017 20:13
@inmysocks
Copy link

I think that it is important to point out that letting an abuser know that their message hasn't gotten through causes more abuse because then they will try and find another channel to use for harassment.

ykzts pushed a commit that referenced this pull request Nov 18, 2017
* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Change `静音` to `隐藏`

* i18n: (zh-CN) Add translations for #5087 & #5669

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Add missing translation for #5728
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017
…todon#5669)

* Add option to block direct messages from people you don't follow

Fix mastodon#5326

* If the DM responds to a toot by recipient, allow it through

* i18n: Update Polish translation (for mastodon#5669) (mastodon#5673)
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017
* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Change `静音` to `隐藏`

* i18n: (zh-CN) Add translations for mastodon#5087 & mastodon#5669

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Add missing translation for mastodon#5728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants