-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to block direct messages from people you don't follow #5669
Conversation
142efab
to
e83c55a
Compare
Looks like this is just a face-lift on the changes Paul and i made and doesn't address the criticism of the change - if a user initiates a direct message with someone they don't follow with the option on, there is no way to see responses from said person, unless I'm misreading your changes. |
@Gargron I think it makes a lot of sense from a UX and product perspective to a do a Reject { Note } for DMs that get filtered due to this option, which would bring us to parity (IMO) with twitter's feature in this area. I understand if you think that's too much complexity though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Errors are probably not critical here
I think that it is important to point out that letting an abuser know that their message hasn't gotten through causes more abuse because then they will try and find another channel to use for harassment. |
* i18n: (zh-CN) Improve translations * i18n: (zh-CN) Change `静音` to `隐藏` * i18n: (zh-CN) Add translations for #5087 & #5669 * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Add missing translation for #5728
…todon#5669) * Add option to block direct messages from people you don't follow Fix mastodon#5326 * If the DM responds to a toot by recipient, allow it through * i18n: Update Polish translation (for mastodon#5669) (mastodon#5673)
* i18n: (zh-CN) Improve translations * i18n: (zh-CN) Change `静音` to `隐藏` * i18n: (zh-CN) Add translations for mastodon#5087 & mastodon#5669 * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Improve translations * i18n: (zh-CN) Add missing translation for mastodon#5728
Fix #5326
I heard some discussion about communicating to the end-user that the message could not be delivered when it's blocked like this, however there are no such indications when notifications are blocked using any other means in NotifyService, and they are generally impossible to implement consistently between local and remote accounts and therefore undesirable. Plus since a direct message is not generally directed as much as it tags one or more people who may or may not see it...