Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge indexes for reblog on statuses table #5831

Merged
merged 1 commit into from
Nov 27, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
class AddIndexAccountAndReblogOfIdToStatuses < ActiveRecord::Migration[5.1]
def change
commit_db_transaction
add_index :statuses, [:account_id, :reblog_of_id], algorithm: :concurrently
disable_ddl_transaction!

def up
# This index has been superseded by migration 20171125185353
# add_index :statuses, [:account_id, :reblog_of_id], algorithm: :concurrently
end

def down
remove_index :statuses, [:account_id, :reblog_of_id] if index_exists?(:statuses, [:account_id, :reblog_of_id])
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class AddIndexReblogOfIdAndAccountToStatuses < ActiveRecord::Migration[5.1]
disable_ddl_transaction!

def change
add_index :statuses, [:reblog_of_id, :account_id], algorithm: :concurrently
end
end
14 changes: 14 additions & 0 deletions db/migrate/20171125190735_remove_old_reblog_index_on_statuses.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
class RemoveOldReblogIndexOnStatuses < ActiveRecord::Migration[5.1]
disable_ddl_transaction!

def up
# This index may not exists (see migration 20171122120436)
remove_index :statuses, [:account_id, :reblog_of_id] if index_exists?(:statuses, [:account_id, :reblog_of_id])

remove_index :statuses, :reblog_of_id
end

def down
add_index :statuses, :reblog_of_id, algorithm: :concurrently
end
end
5 changes: 2 additions & 3 deletions db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20171125031751) do
ActiveRecord::Schema.define(version: 20171125190735) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand Down Expand Up @@ -409,10 +409,9 @@
t.bigint "application_id"
t.bigint "in_reply_to_account_id"
t.index ["account_id", "id"], name: "index_statuses_on_account_id_id"
t.index ["account_id", "reblog_of_id"], name: "index_statuses_on_account_id_and_reblog_of_id"
t.index ["conversation_id"], name: "index_statuses_on_conversation_id"
t.index ["in_reply_to_id"], name: "index_statuses_on_in_reply_to_id"
t.index ["reblog_of_id"], name: "index_statuses_on_reblog_of_id"
t.index ["reblog_of_id", "account_id"], name: "index_statuses_on_reblog_of_id_and_account_id"
t.index ["uri"], name: "index_statuses_on_uri", unique: true
end

Expand Down