Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide statuses from silenced accounts from other silenced accounts #6030

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Dec 15, 2017

No description provided.

@nightpool
Copy link
Member

Personally I think this is a bad idea—I know the original conception of silenced was a sort of hellban, but right now it's very noticeable when you get silenced on a small instance, because the local timeline disappears. Adding things that make it more noticeable seems like the wrong direction.

@Gargron
Copy link
Member Author

Gargron commented Dec 15, 2017

@nightpool I think you misunderstand. This makes it less noticeable, not more. Originally silenced accounts could see their own posts and posts of other silenced accounts. But due to the implementation of StatusFilter that became bugged and silenced accounts could no longer see even their own posts in threads, which made the shadowban very obvious and annoying. This fixes that bug.

Hide this post if:

  • the viewer is NOT silenced
  • AND the author is silenced
  • AND the viewer does NOT follow the author

E.g., if a silenced account views it, do not hide

Copy link
Member

@nightpool nightpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, right, that makes sense.

@nightpool
Copy link
Member

Do we know when this changed? I don't remember it happening last time I was poking the threading code....

@Gargron Gargron merged commit 3d3b403 into master Dec 15, 2017
@Gargron Gargron deleted the fix-silenced-quarantine branch December 15, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants