Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Docker permissions during the build process #6496

Closed
wants to merge 1 commit into from
Closed

Set Docker permissions during the build process #6496

wants to merge 1 commit into from

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Feb 18, 2018

Fix #3194

I'm not sure why @Wonderfall didn't open this PR...

@Gargron Gargron added the deployment Related to runtime configuration, production setups label Feb 18, 2018
Copy link
Member

@moritzheiber moritzheiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using docker-entrypoint.sh after this PR? Can we get rid of it?

@@ -70,10 +72,11 @@ RUN bundle config build.nokogiri --with-iconv-lib=/usr/local/lib --with-iconv-in

COPY . /mastodon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now run chown while copying, which is more efficient and saves you an additional run statement. I'd get rid of the chown statement in line 76 in favor of using COPY --chown=${UID}:${GID}?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could give it a try, indeed.

@Gargron Gargron closed this Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Related to runtime configuration, production setups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants