When creating status, if no sensitive status is given, use default #7057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
reviewed
Apr 6, 2018
app/services/post_status_service.rb
Outdated
| @@ -28,7 +28,7 @@ def call(account, text, in_reply_to = nil, **options) | |||
| status = account.statuses.create!(text: text, | |||
| media_attachments: media || [], | |||
| thread: in_reply_to, | |||
| sensitive: options[:sensitive], | |||
| sensitive: (options[:sensitive].nil? ? account.user&.setting_default_privacy : options[:sensitive]), | |||
There was a problem hiding this comment.
Why setting_default_privacy? That has the values "public", "unlisted", "private", etc...
There was a problem hiding this comment.
Sorry, distraction on my part, fixing
Clients using the API that do not provide the sensitive flag are always posting with false sensitive option.
renatolond
force-pushed
the
bugfix/use_default_sensitive_option_when_creating_status
branch
from
90fe495
to
62ae1a6
Compare
|
Updated :) |
Gargron
approved these changes
Apr 9, 2018
2 tasks
1 task
renatolond
deleted the
bugfix/use_default_sensitive_option_when_creating_status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients using the API that do not provide the sensitive flag are always posting with false sensitive option.