Feature: Allow staff to change user emails #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
commented
Apr 8, 2018
| self.recorded_changes = ActiveSupport::HashWithIndifferentAccess.new( | ||
| email: [target.email, nil], | ||
| unconfirmed_email: [nil, target.unconfirmed_email] | ||
| ) |
There was a problem hiding this comment.
This might be a bit contentious, but essentially in the ActionLog view, you want to see both the current email and what it's been changed to. This isn't captured with target.previous_changes as we're not updating the email directly, but rather requiring confirmation of the email update.
|
On https://github.com/tootsuite/mastodon/pull/7074/files#diff-64be43f43a5e15792e0f9d355cecc7a3 — I've not written many tests from scratch before, so let me know if there's something I should do differently. |
|
Pinging @Gargron for review (perhaps it's an idea to get a "reviewers bot" setup? |
Gargron
approved these changes
Apr 10, 2018
mayaeh
added a commit
to mayaeh/mastodon
that referenced
this pull request
Apr 11, 2018
ykzts
pushed a commit
that referenced
this pull request
Apr 13, 2018
* Update Japanese translations. * Update Japanese translations. * Update Japanese translations. * Update Japanese translations. * Add Japanese translations for #6984, #7040, #7072. Update Japanese translations for privacy policy. * Add Japanese translations for #7032, #7074, #7089. * Proofreading Japanese translations for privacy policy.
2 tasks
Gargron
pushed a commit
that referenced
this pull request
May 21, 2018
* i18n: (zh-CN) #7532 * i18n: (zh-CN) #6984 * i18n: (zh-CN) #7391, #7507 * i18n: (zh-CN) #6998 * i18n: (zh-CN) #7074 * i18n: (zh-CN) #7000, #7032, #7131 (#7032, #7040) * i18n: (zh-CN) #7130, #7188 * i18n: (zh-CN) #6486 * i18n: (zh-CN) #6292 * i18n: (zh-CN) #7347 * i18n: (zh-CN) #6661 * i18n: (zh-CN) #6425 * i18n: (zh-CN) #6597 * i18n: (zh-CN) #6695 * i18n: (zh-CN) #6325 * i18n: (zh-CN) #6460, #7375 * i18n: (zh-CN) #6872 * i18n: (zh-CN) #6818 * i18n: (zh-CN) #7452 * i18n: (zh-CN) #7176 * i18n: (zh-CN) #6460 * i18n: (zh-CN) #7213 * i18n: (zh-CN) #7376 * i18n: (zh-CN) #6556 * i18n: (zh-CN) #6645 * i18n: (zh-CN) #6448 * i18n: (zh-CN) #5303 * i18n: (zh-CN) #7445 * i18n: (zh-CN) Normalization and improvements * i18n: (zh-CN) #7391 * i18n: (zh-CN) #6627 * i18n: (zh-CN) #6956, #7546 * i18n: (zh-CN) #6636 * i18n: (zh-CN) #6610, #6875 * i18n: (zh-CN) #6887 * i18n: (zh-CN) #4514 * i18n: (zh-CN) #6628 * i18n: (zh-CN) #6771 * i18n: (zh-CN) #6772 * i18n: (zh-CN) #7178 * i18n: (zh-CN) #7521 * i18n: (zh-CN) #6570 * i18n: (zh-CN) #6593 * i18n: (zh-CN) #6423 * i18n: (zh-CN) #6157 * i18n: (zh-CN) #7089 * i18n: (zh-CN) #6733 * i18n: (zh-CN) #7072 * i18n: (zh-CN) #6520 * i18n: (zh-CN) Improvment * i18n: (zh-CN) #6631
chendo
pushed a commit
to assemblyfour/switter
that referenced
this pull request
May 28, 2018
* Admin: Show unconfirmed email address on account page * Admin: Allow staff to change user email addresses * ActionLog: On change_email, log current email address and new unconfirmed email address Conflicts: - config/locales/en.yml (resolved manually, conflicted with Report UI changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently on Switter.at, we get a lot of users accidentally signing up with the wrong email address, like, they use
@proton.cominstead of@protonmail.comwhich means they never can finish creating their account.This PR implements the ability for a staff member to find a user and change their email address. The reason it does not issue an
email_changedemail is that the current email address is usually invalid and emailing it would decrease your deliverability stats / increase spam score.The change is captured in the audit log, with details:
The view changes are as follows: