Resize images before upload in web UI to reduce bandwidth #7223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
Apr 22, 2018
unarist
suggested changes
Apr 22, 2018
| }; | ||
|
|
||
| const resizeImage = (inputFile, callback) => { | ||
| if (inputFile.type.match(/image.*/)) { |
There was a problem hiding this comment.
Animated gifs will pass this test and it will lost animation.
There was a problem hiding this comment.
But a GIF image larger than 1280px... is there any point in keeping it animated, since it will be a large file size..?
There was a problem hiding this comment.
but if you do so silently. they won't be aware of losing animation before posting it.
I think most cases will be covered even if we exclude GIFs from this process.
unarist
approved these changes
Apr 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7218