Use real container width in MediaGallery srcSet #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,9 +264,9 @@ export default class MediaGallery extends React.PureComponent { | |||
| const size = media.take(4).size; | |||
|
|
|||
| if (this.isStandaloneEligible()) { | |||
| children = <Item standalone onClick={this.handleClick} attachment={media.get(0)} />; | |||
| children = <Item standalone onClick={this.handleClick} attachment={media.get(0)} displayWidth={width} />; | |||
There was a problem hiding this comment.
It appears to work, but I'm not sure how, as width is undefined when it's rendered for the first time.
There was a problem hiding this comment.
Well, not sure what we can do there. Hardcode a fallback width? That's back to status quo with ~330px
There was a problem hiding this comment.
It's kind of redundant with the CSS, but we can always know which size it is going to be, from the context. That would be best. But apparently it works as is, so… 🤷♂️
luckyyang
added a commit
to open-archive/moooon-network
that referenced
this pull request
May 24, 2018
* commit 'd8864b9e9d4fd56606a3b809bedeb1216b6620ae': (84 commits) Fix caret position after selected suggestion and media upload (mastodon#7595) Fix tests for invites controller (regression from 4d81809) (mastodon#7597) Yeah, it was supposed to be #create? Bump version to 2.4.0 Remove pointer to light theme until it is more polished (mastodon#7594) Remove unneeded code now that attachment URL isn't appended to toots (mastodon#7593) Do not encode HTML entities in initial Web Push payload body (mastodon#7592) [WIP] i18n: Update Simplified Chinese translations (mastodon#7576) Add tests for report notes controller (mastodon#7589) Enforce order on authorized applications page (mastodon#7587) Hide section headline for timelines in production (mastodon#7590) Change column params on pinned timeline (mastodon#7581) Remove outline (mastodon#7582) [RU] Added mastodon-light string (mastodon#7583) 🌍: 🇵🇱⬆️ (mastodon#7580) Save onlyMedia prop when pinning column (mastodon#7575) Display only domain of report account if remote under comment (mastodon#7574) Add exact attribute to WrappedRoute for community timeline (mastodon#7572) Bump version to 2.4.0rc5 Use real container width in MediaGallery srcSet (mastodon#7571) ... # Conflicts: # config/locales/en.yml # config/locales/simple_form.zh-CN.yml # config/locales/zh-CN.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7568