Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin setting to enable OG previews for sensitive media #7962

Merged
merged 1 commit into from Jul 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/admin/settings_controller.rb
Expand Up @@ -21,6 +21,7 @@ class SettingsController < BaseController
activity_api_enabled
peers_api_enabled
show_known_fediverse_at_about_page
preview_sensitive_media
).freeze

BOOLEAN_SETTINGS = %w(
Expand All @@ -31,6 +32,7 @@ class SettingsController < BaseController
activity_api_enabled
peers_api_enabled
show_known_fediverse_at_about_page
preview_sensitive_media
).freeze

UPLOAD_SETTINGS = %w(
Expand Down
2 changes: 2 additions & 0 deletions app/models/form/admin_settings.rb
Expand Up @@ -36,6 +36,8 @@ class Form::AdminSettings
:peers_api_enabled=,
:show_known_fediverse_at_about_page,
:show_known_fediverse_at_about_page=,
:preview_sensitive_media,
:preview_sensitive_media=,
to: Setting
)
end
6 changes: 6 additions & 0 deletions app/views/admin/settings/edit.html.haml
Expand Up @@ -2,6 +2,9 @@
= t('admin.settings.title')

= simple_form_for @admin_settings, url: admin_settings_path, html: { method: :patch } do |f|
.actions.actions--top
= f.button :button, t('generic.save_changes'), type: :submit

.fields-group
= f.input :site_title, placeholder: t('admin.settings.site_title')
= f.input :site_description, wrapper: :with_block_label, as: :text, label: t('admin.settings.site_description.title'), hint: t('admin.settings.site_description.desc_html'), input_html: { rows: 8 }
Expand Down Expand Up @@ -58,5 +61,8 @@
.fields-group
= f.input :peers_api_enabled, as: :boolean, wrapper: :with_label, label: t('admin.settings.peers_api_enabled.title'), hint: t('admin.settings.peers_api_enabled.desc_html')

.fields-group
= f.input :preview_sensitive_media, as: :boolean, wrapper: :with_label, label: t('admin.settings.preview_sensitive_media.title'), hint: t('admin.settings.preview_sensitive_media.desc_html')

.actions
= f.button :button, t('generic.save_changes'), type: :submit
2 changes: 1 addition & 1 deletion app/views/stream_entries/_og_image.html.haml
@@ -1,4 +1,4 @@
- if activity.is_a?(Status) && activity.non_sensitive_with_media?
- if activity.is_a?(Status) && (activity.non_sensitive_with_media? || (activity.with_media? && Setting.preview_sensitive_media))
- player_card = false
- activity.media_attachments.each do |media|
- if media.image?
Expand Down
3 changes: 3 additions & 0 deletions config/locales/en.yml
Expand Up @@ -316,6 +316,9 @@ en:
peers_api_enabled:
desc_html: Domain names this instance has encountered in the fediverse
title: Publish list of discovered instances
preview_sensitive_media:
desc_html: Link previews on other websites will display a thumbnail even if the media is marked as sensitive
title: Show sensitive media in OpenGraph previews
registrations:
closed_message:
desc_html: Displayed on frontpage when registrations are closed. You can use HTML tags
Expand Down
1 change: 1 addition & 0 deletions config/settings.yml
Expand Up @@ -26,6 +26,7 @@ defaults: &defaults
delete_modal: true
auto_play_gif: false
display_sensitive_media: false
preview_sensitive_media: false
reduce_motion: false
system_font_ui: false
noindex: false
Expand Down