Improve federated ID validation #8372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks ok to me, but I'm a bit uneasy with the mess that this code is becoming, so I would like if someone else also reviewed. |
ykzts
approved these changes
Aug 22, 2018
Gargron
added a commit
that referenced
this pull request
Aug 22, 2018
* Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible
dariusk
pushed a commit
to friendcamp/mastodon
that referenced
this pull request
Aug 22, 2018
* Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible
abcang
pushed a commit
to pixiv/mastodon
that referenced
this pull request
Aug 23, 2018
* Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible
edenaes
pushed a commit
to edenaes/mastodon
that referenced
this pull request
Aug 23, 2018
* Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible
lawremipsum
pushed a commit
to lawremipsum/mspsocial-mastodon
that referenced
this pull request
Aug 23, 2018
* Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible
abcang
pushed a commit
to pixiv/mastodon
that referenced
this pull request
Aug 27, 2018
* Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible
kyori19
pushed a commit
to kyori19/mastodon
that referenced
this pull request
Sep 20, 2018
* Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible
Lana-chan
added a commit
to computerfairies/mastodon
that referenced
this pull request
Sep 23, 2018
* Upgrade Doorkeeper to 4.4.1 (mastodon#8197) * Upgrade doorkeeper to 4.4.2 (mastodon#8321) * Improve federated ID validation (mastodon#8372) * Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible * Bump version to 2.4.4 * local only toots?? * allow local-privacy posts in local timeline * don't send local only toots to remote users * fix boost icon for local toots * bug fixes typo in the detailed status bar view, filtering local-only replies from local * change local-only "reblog" icon to a globe also make it disabled in expanded view as well * patch some local-toot escape holes and reblogging * update privacy locale labels * make local-only posts searchable by hashtag, locally * undoing prior "patch" as unnecessary? * fixing logic? * fix reply-to not choosing Local Only * make Local Only icon match default Local icon * fix default-post-level locale setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.