React storybook #91
Merged
React storybook #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
reviewed
Oct 11, 2016
| import { storiesOf, action } from '@kadira/storybook'; | ||
|
|
||
| import './storybook.css' | ||
| // for now just simply $ rake asset:precompile && mv public/assets/application-ebf... storybook/application.css |
There was a problem hiding this comment.
Is this because some of my components use CSS? What's the way forward here? Move the CSS into something like Radium, or the other way around, use CSS modules or whatever they're called..?
There was a problem hiding this comment.
That's just a quick and dirty way to give the components the same style as in the app. Unfortunately I have no clue what's the best way to handle component styling and I hadn't the chance to try radium etc yet. But it would be definitely nice if components would bring their own styles.
alpaca-tc
pushed a commit
to pixiv/mastodon
that referenced
this pull request
Jun 15, 2017
…ns-max-tracks DECKに入れられる最大曲数を表示
Merged
2 tasks
Kirishima21
pushed a commit
to Kirishima21/mastodon
that referenced
this pull request
Jun 23, 2018
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 6, 2023
Chandrn7 openid sso2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I integrated a very useful tool called react-storybook. It basically allows you to create a catalogue of the app's React components. Have a look at the docs to learn more. Please give it a try:
Then open http://localhost:9001/ in a browser.
In my opinion this is a very nice companion to testing. What do you think?