Use summary as summary for converted ActivityPub objects #9823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Jan 16, 2019
|
LGTM. This means such objects can't have a Content Warning though. Maybe use the title as a CW? |
|
I see no good reason to make people click show more, since both the title and the summary of a blog post are typically oriented towards being displayed in public view, while what would be actually hidden by the CW is the main text which is not displayed anyway (link). |
nightpool
reviewed
Jan 16, 2019
| @@ -61,7 +61,7 @@ def process_status_params | |||
| account: @account, | |||
| text: text_from_content || '', | |||
| language: detected_language, | |||
| spoiler_text: text_from_summary || '', | |||
| spoiler_text: converted_object_type? ? '' : (text_from_summary || ''), | |||
There was a problem hiding this comment.
this should be object[:sensitive] or something equivalent, so converted object types can still opt in to CWs
|
aren't there other converted object types besides articles though? |
|
If a video or image is marked sensitive, it will be hidden. Since they don't have other text, it doesn't make sense to to make people click "show more" for nothing. |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-Note objects,
summaryhas a slightly different semantic meaning, and it doesn't make sense to use it as a content warning hiding the title and link to the article. So, for converted object types, display the title, then summary, then the link to the article.Fix #8609