Update to current Node LTS for Dockerfile #9854
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby will use latest Alpine release
|
To confirm, uWS builds on Node 10? I heard this was a problem previously... |
|
Answered on Discord, but: yeah, it builds successfully here via Docker Hub. |
|
The structure of the Dockerfile has been changed significantly so it's best to re-open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby will use latest Alpine release, to match Node using the latest. This will need testing, but I have been using Node 10 for about 2 weeks, and uWS will build on the LTS.
Implementing what I commented in the PR on #9796. My current thinking is that this needs testing but nothing is breaking with streaming, and Webpack seems to respond just fine. There will also be no breaking changes to the Node 10 LTS (semantic versioning).
(Also, Ruby 2.6 itself seems stable on Docker, I'm not getting segfaults still. Yay!)