Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Node.js 12 action deprecation #133

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Address Node.js 12 action deprecation #133

merged 2 commits into from
Dec 21, 2022

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Dec 20, 2022 •
edited
Loading

Supersedes #112, #113

Ref. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Production dependencies are bumped to latest.
Breaking change in Octokit is addressed.

Tested with .env file and following command:

npm install 

node index.js

npm run build
node dist/index.js

My gist are successfully updated both with index.js and dist/index.js

matchai
matchai approved these changes Dec 21, 2022
View reviewed changes
Copy link
Owner

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the fix @exoego 🙏

@matchai matchai merged commit 7c3b60d into matchai:master Dec 21, 2022
@exoego exoego deleted the node16 branch December 21, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matchai matchai matchai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@exoego @matchai