Problem with canonifyurl

[mirisbowring]

What features are affected?

• LandingPage Button (Home)
• showVisitedLinks

What is the current bug behaviour?

If the website is not hosted on a subdomain but a namespace like:

https://www.domain.com/my-namespace/<here is the root>

baseURL = "https://www.domain.com/my-namespace/

following will happen:

• if canonifyURL is enabled:
  • LandingPageButton (Home) is working as expected
  • showVisitedLinks is not working (here we have a strange behaviour):

menu.html
template "section-tree-nav"
...
<li data-nav-id="{{.RelPermalink}}" title="{{.Title}}" class="dd-item {{if eq .File.UniqueID $currentFileUniqueID}}active{{end}}">
        <a href="{{ .RelPermalink}}">
...

though, both are using the .RelPermalink variable, the href also contains the baseURL and the data-nav-id does not!

• if canonifyURL ist NOT enabled
  • landingPageButton (Home) redirects to https://www.domain.com/
  • showVisitedLinks is working as expected

What should the feature behave like?

That`s the question. It looks like we are having 2 bugs.
On the one side, the landing page button should work with and without the canonification.
On the other side, the showVisitedLinks feature should work both ways too.

Proposal

To fix the showVisitedLinks bug, replace .RePermalink with baseURL + path
To Fix the LandingPageButton bug, either mention this behaviour on the documentation and let the user specify the landingpage url (this param does already exist in config.toml) or build the url like showVisitedLinks.

Note

I will make a PR if i have some time left.