-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added task solution #782
base: master
Are you sure you want to change the base?
Added task solution #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The user should be able to choose only one option (yes or no). Fix these radio buttons, pelase
Screen.Recording.2023-04-27.at.12.36.45.mov
- [DEMO LINK](https://kyrylomanko.github.io/layout_html-form/) | ||
- [TEST REPORT LINK](https://kyrylomanko.github.io/layout_html-form/report/html_report/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add these links to the PR description
src/index.html
Outdated
id="surname" | ||
name="surname" | ||
autocomplete="off" | ||
><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need these br
tags everywhere? Remove them
><br> | |
> |
src/index.html
Outdated
<label for="surname">Surname:</label> | ||
<input | ||
cletype="text" | ||
class="distance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use more meaningful class names. For example:
class="distance" | |
class="form-field" |
src/index.html
Outdated
> | ||
|
||
</fieldset> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> | |
</fieldset> | |
> | |
</fieldset> |
src/index.html
Outdated
> | ||
|
||
</fieldset> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add spaces between parent and child elements
> | |
</fieldset> | |
> | |
</fieldset> |
src/style.css
Outdated
margin-bottom: 10px; | ||
} | ||
|
||
fieldset { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't style tags, use class selector instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEMO LINK
TEST REPORT LINK