-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #788
base: master
Are you sure you want to change the base?
add task solution #788
Conversation
@@ -1 +1,17 @@ | |||
/* styles go here */ | |||
.body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'body' instead of '.body' to select the body element.
How old are You? | ||
<input | ||
type="number" | ||
name="How old are You?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a more descriptive name for the 'name' attribute. For example, 'age'.
<label> | ||
<input | ||
type="radio" | ||
name="Yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Radio buttons for the same question should have the same 'name' attribute. Change the 'name' attribute to 'loveCats' for both 'Yes' and 'No' options.
Full date of birth: | ||
<input | ||
type="date" | ||
name="Full date of birth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a more descriptive name for the 'name' attribute. For example, 'dateOfBirth'.
How do you rate our work? | ||
<input | ||
type="range" | ||
name="rate worl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a more descriptive name for the 'name' attribute. For example, 'workRating'.
<select name="car" multiple> | ||
<option value="BMW">BMW</option> | ||
<option value="Audi">Audi</option> | ||
<option value="Jeep">Lada</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option text should match the value attribute. Change the option text to 'Lada' instead of 'Jeep'.
I accept the term of the agreement | ||
<input | ||
type="checkbox" | ||
name="I accept the term of the agreement" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a more descriptive name for the 'name' attribute. For example, 'termsAgreement'.
<div class="form-field"> | ||
Surname: | ||
<input | ||
type="text" | ||
name="Surname" | ||
autocomplete="off" | ||
> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- use label instead of div
- apply code styling recommendations
<div class="form-field"> | |
Surname: | |
<input | |
type="text" | |
name="Surname" | |
autocomplete="off" | |
> | |
</div> | |
<label class="form-field"> | |
Surname: | |
<input | |
type="text" | |
name="Surname" | |
autocomplete="off" | |
> | |
</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, i need chenge oll div to label ?
.form { | ||
margin-bottom: 20px; | ||
|
||
} | ||
|
||
.form-field { | ||
|
||
padding-bottom: 10px; | ||
} | ||
|
||
.form-field:last-child { | ||
padding-bottom: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no needs to add all of these classes.
You may only apply those to your filedset
and form field (label
or div
)
Example:
.form-fieldset:not(:last-child) {
margin-bottom: 20px
}
.form-field:not(:last-child) {
margin-bottom: 10px
}
No description provided.