Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations: America/Godthab was renamed to America/Nuuk #77

Merged
merged 1 commit into from
May 30, 2020
Merged

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented May 22, 2020

Closes #76

@sc0w
Copy link
Member

sc0w commented May 22, 2020

The build fails in fedora

Invalid timezones in ../../../data/Locations.xml.in: America/Nuuk

@raveit65

Fedora:latest has fedora 31, maybe the build will be ok in fedora 32 ?

@raveit65
Copy link
Member

raveit65 commented May 22, 2020

https://hub.docker.com/_/fedora/
I don't know when they change latest, 31 to latest, 32. Fedora 32 is released.
And i don't want to change latest to something else only for fixing one build.
Travis Ci should be helper and not a job machine ;)
Simply ignore it.

Any way, this shows that we shouldn't use this PR for stable 1.24 branch for the moment, because fedora 31 and others use mate-1.24 too.
I am sure other distros with 1.24 can also use the old location.
Debian-testing is an unreleased version of debian, so they can use a patch to fix it.
I don't see no reason to break fedora 31 and other released distros with stable 1.24.

Copy link
Member

@sc0w sc0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be merged to master

I don't know if there is a way to check tzdata version

@raveit65
Copy link
Member

Stable libmateweather-1.24.0 builds fine in fedora 32, so changing travis config is useless.

@raveit65
Copy link
Member

raveit65 commented May 29, 2020

All fedora versions are using tzdata-2020a-1, see https://koji.fedoraproject.org/koji/packageinfo?packageID=50
But debian-testing use also tzdata-2020a-1
https://packages.debian.org/search?suite=bullseye&arch=any&searchon=names&keywords=tzdata
So, i am still wondering which database is used by the check of check-timezones.sh

xmllint --valid --noout ../../../data/Locations.xml.in

../../../data/check-timezones.sh ../../../data/Locations.xml.in

Invalid timezones in ../../../data/Locations.xml.in: America/Nuuk

When we push this to master than we lost option to release tarballs and update gh-pages with fedora.

My idea is to install the updated package in travis buildroot to fix fedora build.
But we really need to know was changed in debian/ubuntu/archlinux ?

Anyone has an idea?

@raveit65
Copy link
Member

Found the problem. tzdata-2020a-1 was hanging around in updates-testing for fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-f2498da5c3
Should be in stable in a few days.

@raveit65
Copy link
Member

All travis builds are successful.
I think most distros are using tzdata-2020a-1, including Slackware.
So , it might be save to use this with 1.24.
By the way, the build issue with older tzdata occurs only during make distcheck and not with normal make command.
So, i am still wondering why @sunweaver had problems to build his package for debian.

@raveit65 raveit65 merged commit ea13e06 into master May 30, 2020
@raveit65 raveit65 deleted the Nuuk branch May 30, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTBFS against tzdata 2020a
3 participants