Touchpad settings: Support edge and two-finger scrolling independently #229

clefebvre · 2016-03-03T13:24:44Z

No description provided.

monsta · 2016-03-09T13:21:18Z

@flexiondotorg: can you please test it on your laptop so we could merge it for 1.14?
You'll need to apply mate-desktop/mate-settings-daemon#137 first.

flexiondotorg · 2016-03-12T08:48:04Z

I don't have a multi touch capable trackpad laptop anymore 😢

monsta · 2016-03-18T09:02:46Z

Hmm... I guess we'll have to merge it then and wait for feedback after 1.14 release...

monsta · 2016-03-18T13:58:13Z

@lukefromdc: maybe you can test this + mate-desktop/mate-settings-daemon#137?
I think it should work the same with GTK+3.

lukefromdc · 2016-03-18T16:27:52Z

I don't know how to do two-fingered scrolling on any laptop, it's one
of those
things I've never used. I will do a test build tomorrow or tonight
anyway, will
be on the road today.

On 3/18/2016 at 9:58 AM, "monsta" wrote:

@lukefromdc: maybe you can test this +

mate-desktop/mate-settings-daemon#137?
I think it should work the same with GTK+3.

—

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

lukefromdc · 2016-03-18T16:40:26Z

A quick GTK3 test build before I hit the road built OK but crashed on
startup,
then relaunched and crashed over and over again on a desktop machine
(no touchpad present).

On 3/18/2016 at 9:58 AM, "monsta" wrote:

@lukefromdc: maybe you can test this +

mate-desktop/mate-settings-daemon#137?
I think it should work the same with GTK+3.

—

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

monsta · 2016-03-18T16:44:56Z

Just in case - did you build mate-desktop/mate-settings-daemon#137 before it? It's needed for this PR to work.

lukefromdc · 2016-03-18T16:47:44Z

Never knew that, and I am about to head out, no more time right now. I
just pulled your whole touchpad-improvements
branch as a tarball from the website, built it and tried to run it.
Wouldn't that patch be in the tarball though?

On 3/18/2016 at 12:44 PM, "monsta" wrote:

Just in case - did you build mate-desktop/mate-settings-daemon#137

before it? It's needed for this PR to work.

—

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

monsta · 2016-03-18T17:01:57Z

Oh... no, I only mentioned it in the comments above. It's not my branch actually, I'm just trying to give it some testing before merging. Unfortunately, I don't have any laptops around to test it myself...

monsta · 2016-03-22T17:12:58Z

@lukefromdc: any luck with testing mate-desktop/mate-settings-daemon#137 + this one?

lukefromdc · 2016-03-22T17:16:01Z

My one test was of the entire branch pulled as a tarball, presumably with
all three commits. The result was an unusable session of mate-settings-daemon
constantly crashing and restarting.

On 3/22/2016 at 1:13 PM, "monsta" notifications@github.com wrote:

@lukefromdc: any luck with testing https://github.com/mate-
desktop/mate-settings-daemon/pull/137 + this one?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-control-
center/pull/229#issuecomment-199912496

monsta · 2016-03-22T17:30:27Z

Well, you'll need the corresponding branch from m-s-d too. Using only one of these two PRs will result in crashes.

lukefromdc · 2016-03-22T17:36:58Z

I won't be able to do that today as I am busy with other things. Also do
remember-this is a desktop, and on the laptop I do have I don't know
how to use two-fingered anything. Right now I am focussed on setting
up a GTK2 partition (which I won't be able to keep for space reasons)
to test out the mate-panel work in GTK2.

On 3/22/2016 at 1:30 PM, "monsta" notifications@github.com wrote:

Well, you'll need the corresponding branch from m-s-d too. Using
only one of these two PRs will result in crashes.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-control-
center/pull/229#issuecomment-199921681

lukefromdc · 2016-03-22T18:29:49Z

OK, I've now got tarballs of both the MCC and MSD branches, will build
and test them together tonight, recover using a Cinnamon seesion if
they break(fsck happens in this kind of work so I prepare for it).

On 3/22/2016 at 1:30 PM, "monsta" notifications@github.com wrote:

Well, you'll need the corresponding branch from m-s-d too. Using
only one of these two PRs will result in crashes.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-control-
center/pull/229#issuecomment-199921681

lukefromdc · 2016-03-23T18:54:42Z

Just built both branches together with GTK 3.20. Built fine, but still
got mate-settings-daemon crashing over and over again.

On 3/22/2016 at 1:30 PM, "monsta" notifications@github.com wrote:

Well, you'll need the corresponding branch from m-s-d too. Using
only one of these two PRs will result in crashes.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-control-
center/pull/229#issuecomment-199921681

monsta · 2016-03-24T08:35:55Z

@raveit65: maybe you could give it a try? Just to check if there will be any crashes...

monsta · 2016-03-24T08:52:09Z

@raveit65 @lukefromdc forgot to tell: it's actually possible to test UI and changes in GSettings even on the desktop, without any touchpad. Just apply this simple patch:

diff --git a/capplets/mouse/mate-mouse-properties.c b/capplets/mouse/mate-mouse-properties.c
index 0a6fb88..b545f9c 100644
--- a/capplets/mouse/mate-mouse-properties.c
+++ b/capplets/mouse/mate-mouse-properties.c
@@ -369,7 +369,7 @@ setup_dialog (GtkBuilder *dialog)
                G_SETTINGS_BIND_DEFAULT);

        /* Trackpad page */
-       if (find_synaptics () == FALSE)
+       if (/*find_synaptics () == */FALSE)
                gtk_notebook_remove_page (GTK_NOTEBOOK (WID ("prefs_widget")), -1);
        else {
                g_settings_bind (touchpad_settings, "touchpad-enabled",

Now the "Touchpad" tab in mate-mouse-properties will always be visible, even when touchpad isn't found in the system. 😄

monsta · 2016-03-24T09:16:02Z

Bumped required m-s-d version to 1.13.1, as per mate-desktop/mate-settings-daemon#137 (comment).

monsta · 2016-03-24T11:44:12Z

@lukefromdc: just tested this + mate-desktop/mate-settings-daemon#137 with GTK+3 (3.18.9). Used the mentioned patch to test UI on the desktop. Well, all works fine, no crashes...

lukefromdc · 2016-03-24T18:00:40Z

The crash I got was in mate-settings-daemon itself, wonder if this is GTK 3.20 specific?

On 3/24/2016 at 7:44 AM, "monsta" notifications@github.com wrote:

@lukefromdc: just tested this + https://github.com/mate-
desktop/mate-settings-daemon/pull/137 with GTK+3 (3.18.9). Used
the mentioned patch to test UI on the desktop. Well, all works
fine, no crashes...

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-control-
center/pull/229#issuecomment-200801212

monsta · 2016-03-25T07:12:31Z

@raveit65: did you see any m-s-d crashes with 3.19/3.20?

raveit65 · 2016-03-25T09:39:44Z

Well, with latest releases m-s-d (mate-settings-daemon-1.13.1-11.fc24.x86_64) i didn't notify any crashes or abrt alarms in fedora 24 on my main box.
I will test now all this stuff here on my notebook, but........
@monsta
Does updating m-c-c and m-s-d work with 1.12 environment?
I use fedora-22 or rhel-7.2 there, and i do not have any free diskspace to set up a third installation with f24 which use 1.13.x.

monsta · 2016-03-25T10:11:40Z

I don't know, didn't test it with 1.12.

raveit65 · 2016-03-25T10:35:24Z

Ok, i can test, fedora 22 use gtk3 version from 1.13 branch, my fault....
......to much different installations here.

raveit65 · 2016-03-25T12:32:24Z

Ok, m-s-d and m-c-c are updated on my notebook (f22)
All settings in touchpad tab are working in a quick test.
And i do not get crashes or abrt alarms with m-s-d.
If those are gtk+-3.20 related, i'm sorry to say i can't test this in the moment.
I won't update my notebook before f24 is released.

Honestly, i don't understand what natural scrolling is, btw. is see no different.

monsta · 2016-03-25T12:49:47Z

Natural scrolling is a reverse scrolling. It's like when you hold left mouse button in atril and drag it to scroll the document. Or same with large pictures in eom. You move mouse down, the document or the picture scrolls up. This is the opposite to scrollbar behaviour, so it's reverse.

I have no idea who first called it "natural", but that person most probably was a smartphone/tablet user. This type of scrolling is performed there using your fingers.

raveit65 · 2016-03-27T09:07:42Z

@monsta
@clefebvre
Fedora 24 alpha freeze is over.
So if you merge this PR + m-s-d PR and release new 1.13.x tarballs, i can build them for fedora 24 and the gtk3 repo, and we have a minimal chance that more people can test this new settings, before we release 1.14.

monsta · 2016-03-27T09:20:02Z

I'd gladly merge it - but Luke has m-s-d crashing right on startup 😕

raveit65 · 2016-03-27T09:31:23Z

Well, up to you, i only wanted to give you an option for more testing 😄
.....we can use it also for 1.6.

XRevan86 · 2016-03-27T10:45:46Z

Looks fine to me. mate-settings-daemon (Gtk2) didn't crash, all settings that worked before work now.
Horizontal scrolling didn't and doesn't work, so are mouse click emulations (MATE settings are simply ignored, two-finger always emulates right click). Probably hardware related.

lukefromdc · 2016-03-27T17:49:58Z

I have not been able to fix this when using tarballs of the msd and mcc
branches in question. Can anyone else test this in GTK 3.20? I will
run another test of this today and see if I can get any information from
the crashes themselves.

On 3/27/2016 at 5:20 AM, "monsta" notifications@github.com wrote:

I'd gladly merge it - but Luke has m-s-d crashing right on startup
😕

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-control-
center/pull/229#issuecomment-202023840

lukefromdc · 2016-03-27T18:20:57Z

I just found the source of the crashes-a stupid build time error on this
end. Go ahead and merge it, the code was never the issue.

I normally build with --disable-schemas-compile so the file build
by recompiling schemas doesn't get copied into my debian packages
by checkinstall. For testing though I was just using make-install, and
this change includes schema changes. Had I been building .debs they
would have been recompiled when the .debs were installed, but not
on a make install with this build option, thus the crash on wrong schemas.

On 3/27/2016 at 5:20 AM, "monsta" notifications@github.com wrote:

I'd gladly merge it - but Luke has m-s-d crashing right on startup
😕

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/mate-desktop/mate-control-
center/pull/229#issuecomment-202023840

monsta · 2016-03-27T19:17:28Z

Well, good it's solved at last 😄

clefebvre and others added 4 commits March 25, 2016 11:58

Touchpad settings: Support edge and two-finger scrolling independently

f6f179c

touchpad: fix alignment of "click emulation" labels

173a836

touchpad: fix some accelerators

9da401e

configure.ac: require m-s-d 1.13.1 for build

ab1e89c

raveit65 force-pushed the touchpad-improvements branch from d046210 to ab1e89c Compare March 25, 2016 10:59

monsta merged commit ab1e89c into master Mar 27, 2016

monsta deleted the touchpad-improvements branch March 27, 2016 19:17

mesov mentioned this pull request Jul 5, 2023

Touchpad scrolling behavior does not match checkbox selection in Mouse Preferences #709

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Touchpad settings: Support edge and two-finger scrolling independently #229

Touchpad settings: Support edge and two-finger scrolling independently #229

clefebvre commented Mar 3, 2016

monsta commented Mar 9, 2016

flexiondotorg commented Mar 12, 2016

monsta commented Mar 18, 2016

monsta commented Mar 18, 2016

lukefromdc commented Mar 18, 2016

lukefromdc commented Mar 18, 2016

monsta commented Mar 18, 2016

lukefromdc commented Mar 18, 2016

monsta commented Mar 18, 2016

monsta commented Mar 22, 2016

lukefromdc commented Mar 22, 2016

monsta commented Mar 22, 2016

lukefromdc commented Mar 22, 2016

lukefromdc commented Mar 22, 2016

lukefromdc commented Mar 23, 2016

monsta commented Mar 24, 2016

monsta commented Mar 24, 2016

monsta commented Mar 24, 2016

monsta commented Mar 24, 2016

lukefromdc commented Mar 24, 2016

monsta commented Mar 25, 2016

raveit65 commented Mar 25, 2016

monsta commented Mar 25, 2016

raveit65 commented Mar 25, 2016

raveit65 commented Mar 25, 2016

monsta commented Mar 25, 2016

raveit65 commented Mar 27, 2016

monsta commented Mar 27, 2016

raveit65 commented Mar 27, 2016

XRevan86 commented Mar 27, 2016

lukefromdc commented Mar 27, 2016

lukefromdc commented Mar 27, 2016

monsta commented Mar 27, 2016

Touchpad settings: Support edge and two-finger scrolling independently #229

Touchpad settings: Support edge and two-finger scrolling independently #229

Conversation

clefebvre commented Mar 3, 2016

monsta commented Mar 9, 2016

flexiondotorg commented Mar 12, 2016

monsta commented Mar 18, 2016

monsta commented Mar 18, 2016

lukefromdc commented Mar 18, 2016

lukefromdc commented Mar 18, 2016

monsta commented Mar 18, 2016

lukefromdc commented Mar 18, 2016

monsta commented Mar 18, 2016

monsta commented Mar 22, 2016

lukefromdc commented Mar 22, 2016

monsta commented Mar 22, 2016

lukefromdc commented Mar 22, 2016

lukefromdc commented Mar 22, 2016

lukefromdc commented Mar 23, 2016

monsta commented Mar 24, 2016

monsta commented Mar 24, 2016

monsta commented Mar 24, 2016

monsta commented Mar 24, 2016

lukefromdc commented Mar 24, 2016

monsta commented Mar 25, 2016

raveit65 commented Mar 25, 2016

monsta commented Mar 25, 2016

raveit65 commented Mar 25, 2016

raveit65 commented Mar 25, 2016

monsta commented Mar 25, 2016

raveit65 commented Mar 27, 2016

monsta commented Mar 27, 2016

raveit65 commented Mar 27, 2016

XRevan86 commented Mar 27, 2016

lukefromdc commented Mar 27, 2016

lukefromdc commented Mar 27, 2016

monsta commented Mar 27, 2016