Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support desktop actions #511

Closed
wants to merge 1 commit into from
Closed

support desktop actions #511

wants to merge 1 commit into from

Conversation

dnk
Copy link
Contributor

@dnk dnk commented Jan 2, 2017

No description provided.

@lukefromdc
Copy link
Member

I'm not sure what "desktop actions" are in this context but a build of this branch worked fine. Looking over the code I do see some general updating as well. The changes will need to be rebased, as your branch has diverged over time and gives a messy commit history and changelog in a test merge in a dummy repo.

@dnk
Copy link
Contributor Author

dnk commented Jan 13, 2017

@raveit65
Copy link
Member

raveit65 commented Jan 13, 2017

I saw those actions in gedit desktop file a while ago, now i know for what is good for.

@raveit65
Copy link
Member

It works fine with gedit as panel launcher.
And deprecated GtkStock is replaced with GIcon w/o removing icons from menus.
So it looks OK with a quick run test of the panel.
I tested this with a build from git master.

Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine

@raveit65
Copy link
Member

Btw. looks like that firefox desktop file use desktop actions too.

@lukefromdc
Copy link
Member

Merged with 7ee4507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants