media-keys: Add microphone mute key support #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing the microphone mute button now toggles the mute status. Fix #175 Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
raveit65
approved these changes
Dec 4, 2018
lukefromdc
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
This is REALLY nice, even includes an OSD for mic muted or not. Memory management looks good, as the only new pointer variables I noticed point to the existing streams we don't want to free and are handled the same way as all the others. Looks good to go here. Tested with the mate-control-center commit used used Ctrl+Audio Mute as the key combo for it
lukefromdc
pushed a commit
to mate-desktop/mate-control-center
that referenced
this pull request
Dec 5, 2018
Provided additional "mic-mute" key binding. For reference: mate-desktop/mate-settings-daemon#253 Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
|
Tested actual audio recording from both an actual microphone and from "monitor of stereo output" in Audacity, muting worked fine, turning the sound being recorded on and off in both cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing the microphone mute button now toggles the mute status.
Fix #175