media-keys: Execute default calculator application defined by schema #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
lukefromdc
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
See
mate-desktop/mate-desktop#341 (review)
this works but the companion commit to mate-desktop needs a makefile update to install the schema and with galculator isn't found we get an error dialog until the perferred calculator is set in mate-control-center.
|
Mate-desktop is now ready, so we can merge all of these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Removes if-elif-else ladder that determines which calculator application to open when XF86Calculator is pressed
• Instead, when XF86Calculator is pressed, m-s-d executes the command listed in the default calculator application schema (defined in commit mate-desktop/mate-desktop@3281160), And this PR is dependent on it
• Relevant PR:
mate-desktop/mate-desktop#341