New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default-applications: Add a widget for a default calculator application #398
Conversation
Fix #291 Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR works, but the companion mate-desktop commit needs a Makefile.am revision. The error dialog instead of fallback to mate-calc, then gnome-calculator when galculator is not found has nothing to do with this PR, which is about being able to set the user's preferred calculator. That just plain works once the mate-desktop install is fixed. See
Note that when opening mate-control-center from terminal and selecting perferred applications you will get |
Prevent runtime failture on g_icon_to_string in fill_combo_box by catching the NULL case See mate-desktop#398 (comment) Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
This is because that default application's .desktop file misses default icon "Icon=***" string. @lukefromdc |
Prevent runtime failture on g_icon_to_string in fill_combo_box by catching the NULL case See mate-desktop#398 (comment) Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
Prevent runtime failture on g_icon_to_string in fill_combo_box by catching the NULL case See #398 (comment) Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
Prevent runtime failture on g_icon_to_string in fill_combo_box by catching the NULL case See #398 (comment) Signed-off-by: Zhang Xianwei <zhang.xianwei8@zte.com.cn>
• Exposes a widget in Preferred Applications to control the default calculator application schema defined in commit mate-desktop/mate-desktop@3281160
• In order to function properly, this PR is dependent on the merger of these two PRs:
• Also fix #291