plugins: fix undefined references #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the plugins depend on the libX11 and libXi linker flags, but they are missing. With GNU libtool the -no-undefined flag is silently ignored so the build succeeds, but with slibtool is correctly sets -Wl,--no-undefined in the linker flags. Gentoo issue: https://bugs.gentoo.org/922326
Many of the plugins depend on mate_settings_plugin_get_type(), but this symbol is only available at runtime in the mate-settings-daemon program. With GNU libtool the -no-undefined flag gets silently ignored and the build succeeds, but with slibtool it correctly sets -Wl,--no-undefined in the LDFLAGS causing the build to fail. To solve this simply removing -no-undefined is enough. Gentoo issue: https://bugs.gentoo.org/922326
|
I simply don't know enough about the build system to properly evaluate this, so leaving it for other team members |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the plugins have undefined references, but with GNU libtool it silently ignores the
-no-undefinedflag so the build succeeds. With slibtool it correctly sets-Wl,--no-undefinedin the linker flags causing the build to fail.Please view the commit messages for more details. The alternative to removing
-no-undefinedin the last commit is to turn most ofmate-settings-daemoninto a convenience library and link that into most of the plugins, but that doesn't seem correct.This was reported for Gentoo: https://bugs.gentoo.org/922326