Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: fix undefined references #413

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

plugins: fix undefined references #413

wants to merge 3 commits into from

Commits on Mar 17, 2024

  1. build: escape newline

    @orbea
    orbea committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    8a9172a View commit details
    Browse the repository at this point in the history

  2. plugins: add missing x11 linker flags 

    Many of the plugins depend on the libX11 and libXi linker flags, but
they are missing.

With GNU libtool the -no-undefined flag is silently ignored so the build
succeeds, but with slibtool is correctly sets -Wl,--no-undefined in the
linker flags.

Gentoo issue: https://bugs.gentoo.org/922326
    @orbea
    orbea committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    15808c2 View commit details
    Browse the repository at this point in the history

  3. configure.ac: don't link plugins with -no-undefined 

    Many of the plugins depend on mate_settings_plugin_get_type(), but this
symbol is only available at runtime in the mate-settings-daemon program.

With GNU libtool the -no-undefined flag gets silently ignored and the
build succeeds, but with slibtool it correctly sets -Wl,--no-undefined
in the LDFLAGS causing the build to fail.

To solve this simply removing -no-undefined is enough.

Gentoo issue: https://bugs.gentoo.org/922326
    @orbea
    orbea committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    7e24263 View commit details
    Browse the repository at this point in the history