Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Next and Find Previous don't work #199

Closed
sc0w opened this issue Nov 2, 2017 · 12 comments
Closed

Find Next and Find Previous don't work #199

sc0w opened this issue Nov 2, 2017 · 12 comments

Comments

@sc0w
Copy link
Member

sc0w commented Nov 2, 2017

It doesn't work in mate-terminal 1.18.1, 1.16.3 and 1.14.0 (debian testing/buster)

It works in mate-terminal 1.8.1 (debian jessie VM)

@monsta
Copy link
Contributor

monsta commented Nov 2, 2017

I see that - but only in Debian systems for some reason. Menu items for both actions are greyed out, and keybindings don't work. But it doesn't happen in various Ubuntu releases. 😕

@sc0w
Copy link
Member Author

sc0w commented Nov 2, 2017

@monsta weird, what mate-terminal ubuntu version works for you?

@monsta
Copy link
Contributor

monsta commented Nov 3, 2017

I tried several systems and mate-terminal versions.

Works with:

  • git master, Mint 18.2 [based on Ubuntu 16.04]
  • 1.18.1, LMDE 2 [based on Debian Jessie]
  • 1.18.1, Ubuntu MATE 17.10
  • 1.18.0, Ubuntu MATE 17.04
  • 1.16.3, Mint 18.1 [based on Ubuntu 16.04]

Doesn't work with:

  • git master, Debian Stretch
  • git master, Debian Testing
  • 1.16.3, Debian Stretch

@raveit65
Copy link
Member

raveit65 commented Nov 3, 2017

Menu items for both actions are greyed out, and keybindings don't work.

Problem exists in fedora 26 with builds from 1.19.x and 1.18.1.
Problem with vte?
[rave@mother mate-terminal-compile]$ rpm -qa vte291*
vte291-0.48.4-1.fc26.x86_64

@monsta
Copy link
Contributor

monsta commented Nov 3, 2017

Not sure - Ubuntu 17.10 also has 0.48.4, and the feature works...

@raveit65
Copy link
Member

raveit65 commented Nov 3, 2017

Issue still exists in f25 with m-t-1.18.1 and
[rave@f25 ~]$ rpm -qa vte291
vte291-0.46.3-1.fc25.x86_64

@raveit65
Copy link
Member

raveit65 commented Nov 3, 2017

Same problem in rhel7.4 with m-t compiled with gtk3.
[rave@qemu-rhel7 ~]$ rpm -qa mate-terminal
mate-terminal-1.16.3-1.el7.x86_64
[rave@qemu-rhel7 ~]$ rpm -qa vte291
vte291-0.46.2-1.el7.x86_64

@raveit65
Copy link
Member

raveit65 commented Nov 3, 2017

But i know that ubuntu vte291 is patched and use fixes for other issues which aren't in vte291 git, ie.
a working background from gtk theme settings.

@sc0w
Copy link
Member Author

sc0w commented Nov 3, 2017

with gnome-terminal 3.26.1 it works

@monsta
Copy link
Contributor

monsta commented Nov 4, 2017

Need to check when/why the menuitems for these actions can be disabled.

sc0w added a commit to sc0w/mate-terminal that referenced this issue Nov 4, 2017
sc0w added a commit to sc0w/mate-terminal that referenced this issue Nov 4, 2017
sc0w added a commit to sc0w/mate-terminal that referenced this issue Nov 4, 2017
sc0w added a commit to sc0w/mate-terminal that referenced this issue Nov 7, 2017
@monsta
Copy link
Contributor

monsta commented Nov 8, 2017

Ok, Ubuntu 17.10 indeed has some patch related to regular expressions for VTE 0.48.

Previous Ubuntu versions and Debian Jessie use VTE older than 0.46, so the problem can't appear there.

raveit65 pushed a commit that referenced this issue Nov 8, 2017
@monsta
Copy link
Contributor

monsta commented Nov 8, 2017

As I found out, in Ubuntu 17.10 #200 has the reverse effect, probably due to their VTE patch. Search shortcuts worked before, now they didn't. I don't know what they did with VTE, and we need the fix for other distros, so it's merged now.

@flexiondotorg FYI

monsta pushed a commit that referenced this issue Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants