[Catalog][Predictive Back][Navigation Drawer] Update navigation drawer state handling to be more accurate in demo #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r state handling to be more accurate in demos
…r state handling to be more accurate in demos
…r state handling to be more accurate in demo
dsn5ft
reviewed
Sep 27, 2023
| if (drawerOnBackAnimationCallback == null) { | ||
| drawerOnBackAnimationCallback = createOnBackAnimationCallback(); | ||
| } | ||
| drawerLayout.post( |
There was a problem hiding this comment.
@manabu-nakamura btw removing this post breaks the predictive back behavior in the normal flow - i.e. when a drawer is opened regularly without rotating the screen.
There was a problem hiding this comment.
Thank you. Does it break the predictive back behavior in the normal flow? There is no problem with Android Emulator 32.1.15 (Google APIs Intel x86_64 Atom System Image, API Level 34, Revision 8).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3593
This is for only CustomNavigationDrawerDemoActivity.