[Layouts] Add an InsetDividerLinearLayout component #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadfisher
force-pushed
the
inset-divider-linear-layout
branch
from
ba935d2
to
8bdbfc9
Compare
Ref material-components#7 Adds a standalone modification to LinearLayoutCompat which allows for control over divider insets. Users may specify "start" and "end" insets, which affect the appropriate dimension in both horizontal and vertical orientations, as well as LTR and RTL layout directions. Users may also specify which dividers to inset, similar to the `showDividers` attribute. To make it easier to adhere to the Material Design baseline grid, dividers are drawn over child views instead of offsetting them. This also allows for backgrounds to be set directly on children without leaving gaps where they would normally be offset. * https://material.io/guidelines/layout/metrics-keylines.html#metrics-keylines-baseline-grids Additionally, start/end dividers are drawn outside of the layout's padding by ignoring child dimensions and simply drawing them along the top/bottom (in vertical orientation) or left/right (in horizontal orientation) edges of the layout. This makes it easier to apply the recommended top/bottom padding to the layout per the Lists spec. * https://material.io/guidelines/components/lists.html#lists-specs Tests were added to verify some basic behavior as well as covering all permutations of inset mode, orientation, and layout direction. These pass on emulators from platform versions 2.3.7 to 7.1.1.
tadfisher
force-pushed
the
inset-divider-linear-layout
branch
from
8bdbfc9
to
32d4007
Compare
JakeWharton
reviewed
Dec 17, 2016
| return (mApplyInsets & INSET_DIVIDER_END) != 0; | ||
| } | ||
|
|
||
| int getFirstVisibleChildIndex() { |
| return Integer.MAX_VALUE; | ||
| } | ||
|
|
||
| int getLastVisibleChildIndex() { |
| } | ||
| } | ||
|
|
||
| void drawDividersHorizontal(Canvas canvas) { |
There was a problem hiding this comment.
private? +the next two methods
|
Thanks for the PR! We're catching up from holidays and new year planning. But we'll be giving this more attention soon! |
|
Since this pr is quite old and there were no pings we're going to close it for now. If it is still a desirable addition to the library please ping on this pr. We'll reopen it and take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #7
Adds a standalone modification to LinearLayoutCompat which allows for
control over divider insets. Users may specify "start" and "end" insets,
which affect the appropriate dimension in both horizontal and vertical
orientations, as well as LTR and RTL layout directions. Users may also
specify which dividers to inset, similar to the
showDividersattribute.
To make it easier to adhere to the Material Design baseline grid,
dividers are drawn over child views instead of offsetting them. This
also allows for backgrounds to be set directly on children without
leaving gaps where they would normally be offset.
Additionally, start/end dividers are drawn outside of the layout's
padding by ignoring child dimensions and simply drawing them along the
top/bottom (in vertical orientation) or left/right (in horizontal
orientation) edges of the layout. This makes it easier to apply the
recommended top/bottom padding to the layout per the Lists spec.
Tests were added to verify some basic behavior as well as covering all
permutations of inset mode, orientation, and layout direction. These
pass on emulators from platform versions 2.3.7 to 7.1.1.