Skip to content

Commit

Permalink
[Slider] Rename thumbIsHollowAtStart to isThumbHollowAtStart
Browse files Browse the repository at this point in the history
Summary: Per Junius' suggestion, this name fits better with the convention of BOOL var names.

Reviewers: O1 Material components iOS, randallli, junius

Reviewed By: O1 Material components iOS, randallli, junius

Tags: #material_components_ios

Differential Revision: http://codereview.cc/D1520
  • Loading branch information
Max Luzuriaga committed Aug 24, 2016
1 parent 5163f7d commit 14e1943
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Expand Up @@ -116,7 +116,7 @@ - (void)applyModel:(MDCSliderModel *)model {
_slider.value = model.value;
_slider.filledTrackAnchorValue = model.anchorValue;
_slider.shouldDisplayDiscreteValueLabel = model.discreteValueLabel;
_slider.thumbIsHollowAtStart = model.hollowCircle;
_slider.isThumbHollowAtStart = model.hollowCircle;
_slider.enabled = model.enabled;

// Add target/action pair
Expand Down
2 changes: 1 addition & 1 deletion components/Slider/src/MDCSlider.h
Expand Up @@ -148,7 +148,7 @@ IB_DESIGNABLE
Defaults to YES.
*/
@property(nonatomic, assign) BOOL thumbIsHollowAtStart;
@property(nonatomic, assign) BOOL isThumbHollowAtStart;

@end

Expand Down
6 changes: 3 additions & 3 deletions components/Slider/src/MDCSlider.m
Expand Up @@ -168,12 +168,12 @@ - (void)setShouldDisplayDiscreteValueLabel:(BOOL)shouldDisplayDiscreteValueLabel
_thumbTrack.shouldDisplayDiscreteValueLabel = shouldDisplayDiscreteValueLabel;
}

- (BOOL)thumbIsHollowAtStart {
- (BOOL)isThumbHollowAtStart {
return _thumbTrack.thumbIsHollowAtStart;
}

- (void)setThumbIsHollowAtStart:(BOOL)thumbIsHollowAtStart {
_thumbTrack.thumbIsHollowAtStart = thumbIsHollowAtStart;
- (void)setIsThumbHollowAtStart:(BOOL)isThumbHollowAtStart {
_thumbTrack.thumbIsHollowAtStart = isThumbHollowAtStart;
}

#pragma mark - MDCThumbTrackDelegate methods
Expand Down

0 comments on commit 14e1943

Please sign in to comment.