Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Collections] Fix header info view z-index (#1798)
The Info Bar view wasn't correctly applying the z-index value from the
LayoutAttributes. This resulted in the header appearing behind the
collectionView cells on iOS 11.
Closes #1786
- Loading branch information
Robert Moore
committed
Aug 14, 2017
1 parent
0ee2751
commit 155a397
Showing
2 changed files
with
63 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
components/Collections/tests/unit/MDCCollectionInfoBarViewTests.m
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
Copyright 2017-present the Material Components for iOS authors. All Rights Reserved. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
#import <XCTest/XCTest.h> | ||
#import "MDCCollectionInfoBarView.h" | ||
|
||
@interface MDCCollectionInfoBarViewTests : XCTestCase | ||
|
||
@end | ||
|
||
@implementation MDCCollectionInfoBarViewTests | ||
|
||
- (void)testAppliesZIndexForKindHeader { | ||
// Given | ||
UICollectionViewLayoutAttributes *layoutAttributes = [UICollectionViewLayoutAttributes | ||
layoutAttributesForSupplementaryViewOfKind:MDCCollectionInfoBarKindHeader | ||
withIndexPath:[NSIndexPath indexPathWithIndex:0]]; | ||
MDCCollectionInfoBarView *infoBarView = | ||
[[MDCCollectionInfoBarView alloc] initWithFrame:CGRectZero]; | ||
layoutAttributes.zIndex = 5; | ||
|
||
// When | ||
[infoBarView applyLayoutAttributes:layoutAttributes]; | ||
|
||
// Then | ||
XCTAssertEqual(infoBarView.layer.zPosition, layoutAttributes.zIndex); | ||
} | ||
|
||
- (void)testAppliesZIndexForKindFooter { | ||
// Given | ||
UICollectionViewLayoutAttributes *layoutAttributes = [UICollectionViewLayoutAttributes | ||
layoutAttributesForSupplementaryViewOfKind:MDCCollectionInfoBarKindFooter | ||
withIndexPath:[NSIndexPath indexPathWithIndex:0]]; | ||
MDCCollectionInfoBarView *infoBarView = | ||
[[MDCCollectionInfoBarView alloc] initWithFrame:CGRectZero]; | ||
layoutAttributes.zIndex = 5; | ||
|
||
// When | ||
[infoBarView applyLayoutAttributes:layoutAttributes]; | ||
|
||
// Then | ||
XCTAssertEqual(infoBarView.layer.zPosition, layoutAttributes.zIndex); | ||
} | ||
|
||
@end |