Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ActionSheet] Try to fix MaterialComponentsAlpha (#5541)
With these changes I'm able to create a project with `MaterialComponentsAlpha` in its Podile and import `MaterialComponentsAlpha.MaterialActionSheet` into a Swift file in said project without getting the "Could not build Objective-C module" error message.
`@import MaterialComponents.MaterialTypographyScheme;` and `#import <MaterialComponents/MaterialTypographyScheme.h>` both seem to work. With the `#import` statement you can jump to the definition, and with the `@import` statement you can't, which is a little weird!
This change also brings the number of validation errors from running `pod lib lint MaterialComponentsAlpha.podspec` from 6 down to 1. I haven't figured out how to get rid of the last one, which is a little concerning, and suggests that this may not be a complete fix? Hmmm. The compilation errors seem to be fixed though!
Closes #5380. Maybe.
The necessary internal changes can be seen at cl/220325160
- Loading branch information
1 parent
43a9966
commit 7472e89
Showing
5 changed files
with
9 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters