[ActionSheet] Allow changing action item accessibility labels. (#5803)

i.e.: We need to show the title as "Resume". But the voice over message should be "Résumé" instead of "Rezoom".
material-components · Dec 6, 2018 · f60be33 · f60be33
1 parent 68ea954
commit f60be33
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 0 deletions.
diff --git a/components/ActionSheet/src/MDCActionSheetController.m b/components/ActionSheet/src/MDCActionSheetController.m
@@ -56,6 +56,7 @@ - (id)copyWithZone:(__unused NSZone *)zone {
                                                          image:self.image
                                                        handler:self.completionHandler];
   action.accessibilityIdentifier = self.accessibilityIdentifier;
+  action.accessibilityLabel = self.accessibilityLabel;
   return action;
 }
 

diff --git a/components/ActionSheet/src/private/MDCActionSheetItemTableViewCell.m b/components/ActionSheet/src/private/MDCActionSheetItemTableViewCell.m
@@ -143,6 +143,7 @@ - (void)commonMDCActionSheetItemViewInit {
 - (void)layoutSubviews {
   [super layoutSubviews];
 
+  self.actionLabel.accessibilityLabel = _itemAction.accessibilityLabel;
   self.actionLabel.text = _itemAction.title;
   CGFloat leadingConstant;
   if (_itemAction.image) {
@@ -159,6 +160,7 @@ - (void)layoutSubviews {
 
 - (void)setAction:(MDCActionSheetAction *)action {
   _itemAction = [action copy];
+  self.actionLabel.accessibilityLabel = _itemAction.accessibilityLabel;
   self.actionLabel.text = _itemAction.title;
   self.actionImageView.image = _itemAction.image;
   [self setNeedsLayout];

diff --git a/components/ActionSheet/tests/unit/MDCActionSheetTableCellTest.m b/components/ActionSheet/tests/unit/MDCActionSheetTableCellTest.m
@@ -152,4 +152,20 @@ - (void)testSetActionFont {
   }
 }
 
+- (void)testSetActionItemAccessibilityLabel {
+  // Given
+  MDCActionSheetAction *action = [MDCActionSheetAction actionWithTitle:@"Resume"
+                                                                 image:nil
+                                                               handler:nil];
+  action.accessibilityLabel = @"Résumé";
+
+  // When
+  [self.actionSheet addAction:action];
+  MDCActionSheetItemTableViewCell *cell =
+      [MDCActionSheetTestHelper getCellFromActionSheet:self.actionSheet atIndex:0];
+
+  // Then
+  XCTAssertEqual(cell.actionLabel.accessibilityLabel, action.accessibilityLabel);
+}
+
 @end
diff --git a/components/ActionSheet/tests/unit/MDCActionSheetTestHelper.h b/components/ActionSheet/tests/unit/MDCActionSheetTestHelper.h
@@ -35,4 +35,7 @@
 + (NSArray<MDCActionSheetItemTableViewCell *> *)getCellsFromActionSheet:
     (MDCActionSheetController *)actionSheet;
 
++ (MDCActionSheetItemTableViewCell *)getCellFromActionSheet:(MDCActionSheetController *)actionSheet
+                                                    atIndex:(NSUInteger)index;
+
 @end
diff --git a/components/ActionSheet/tests/unit/MDCActionSheetTestHelper.m b/components/ActionSheet/tests/unit/MDCActionSheetTestHelper.m
@@ -64,4 +64,17 @@ + (void)addNumberOfActions:(NSUInteger)actionsCount
   return cellsArray;
 }
 
++ (MDCActionSheetItemTableViewCell *)getCellFromActionSheet:(MDCActionSheetController *)actionSheet
+                                                    atIndex:(NSUInteger)index {
+  if (index < actionSheet.actions.count) {
+    NSIndexPath *indexPath = [NSIndexPath indexPathForRow:index inSection:0];
+    UITableView *table = actionSheet.tableView;
+    UITableViewCell *cell = [table.dataSource tableView:table cellForRowAtIndexPath:indexPath];
+    if ([cell isKindOfClass:[MDCActionSheetItemTableViewCell class]]) {
+      return (MDCActionSheetItemTableViewCell *)cell;
+    }
+  }
+  return nil;
+}
+
 @end