Enable Catalyst support for the catalogs. #10059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turning this support on revealed a new class of error: ``` Implicit conversion from integral type 'int' to 'BOOL' ``` These errors have been fixed where applicable. Note that due to https://stackoverflow.com/questions/58547010/ios-catalyst-cocoapod-framework-error-signing-requires-a-development-team, each of the icons pod targets needs to have its Signing Certificate value manually set to "Sign to Run Locally". Due to onmyway133/blog#572 we also need to disable Library Validation on the projects.
|
This PR affects multiple components. |
material-automation
bot
added
[Catalog]
[CollectionCells]
[Collections]
[NavigationDrawer]
labels
components/NavigationDrawer/src/private/MDCBottomDrawerContainerViewController.m
Outdated
Show resolved
Hide resolved
|
This PR affects multiple components. |
wenyuzhang666
approved these changes
Aug 11, 2020
|
This PR affects multiple components. |
|
This PR affects multiple components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning this support on revealed a new class of error:
These errors have been fixed where applicable.
Note that due to https://stackoverflow.com/questions/58547010/ios-catalyst-cocoapod-framework-error-signing-requires-a-development-team, each of the icons pod targets needs to have its Signing Certificate value manually set to "Sign to Run Locally".
Separately, due to onmyway133/blog#572 we also need to disable Library Validation on the projects.