Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextFields] Fix text fields overlapping labels #2163

Merged
merged 6 commits into from Oct 13, 2017
Merged

[TextFields] Fix text fields overlapping labels #2163

merged 6 commits into from Oct 13, 2017

Conversation

willlarche
Copy link
Collaborator

Closes #2152

@willlarche
Copy link
Collaborator Author

Also includes this case added to tests and examples.

@willlarche
Copy link
Collaborator Author

Awaiting Travis.

@codecov-io
Copy link

codecov-io commented Oct 13, 2017 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (develop@c882c65). Click here to learn what that means.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2163   +/-   ##
==========================================
  Coverage           ?   45.76%           
==========================================
  Files              ?      230           
  Lines              ?    22292           
  Branches           ?     1880           
==========================================
  Hits               ?    10203           
  Misses             ?    12078           
  Partials           ?       11
Impacted Files Coverage Δ
...xtFields/src/MDCTextInputControllerLegacyDefault.m 90.06% <100%> (ø)
...nts/TextFields/src/MDCTextInputControllerDefault.m 63.58% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c882c65...db7bac8. Read the comment docs.

@willlarche willlarche merged commit 75cf565 into material-components:develop Oct 13, 2017
@willlarche willlarche deleted the fix-textFields-overlappingLabels branch October 13, 2017 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsecord ajsecord ajsecord approved these changes

@jgunaratne jgunaratne jgunaratne approved these changes

Assignees
No one assigned
Labels
cla: yes [TextFields]
Projects
None yet
Milestone
No milestone
8 participants
@willlarche @codecov-io @ajsecord @jgunaratne @ianegordon @romoore @chuga @googlebot