[FeatureHighlight] FeatureHighlightViewController should expose FeatureHighlightView as a property. #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utator. Tests added. Example updated.
…r to a mutator." This reverts commit 0b5433e.
…ponents-ios into develop
…ponents-ios into develop
…ponents-ios into develop
…rial-components-ios into Feature_Highlights_Expose_Typography_API
…rial-components-ios into Feature_Highlights_Expose_Typography_API
|
Blocked until we determine our theming strategy. |
ianegordon
previously requested changes
Mar 27, 2018
| @@ -250,51 +219,35 @@ - (void)setTitleColor:(UIColor *)titleColor { | |||
| _titleLabel.textColor = titleColor; | |||
| } | |||
|
|
|||
| - (UIFont *)defaultTitleFont { | |||
There was a problem hiding this comment.
Make into a class method.
There was a problem hiding this comment.
Should this be a readonly class property instead of a method? Do we have a preference either way?
| [self updateBodyFont]; | ||
| } | ||
|
|
||
| - (UIFont *)defaultBodyFont { |
There was a problem hiding this comment.
Make into a class method.
…ponents-ios into Feature_Highlights_Expose_Typography_API
ianegordon
approved these changes
Mar 27, 2018
|
Kokoro failure is unrelated. |
randallli
reviewed
Mar 30, 2018
|
|
||
| Alpha should be set to kMDCFeatureHighlightOuterHighlightAlpha. | ||
| */ | ||
| @property(nonatomic, strong, null_resettable) UIColor *outerHighlightColor; |
There was a problem hiding this comment.
there are internal clients that are using this and the other properties. We should mark them deprecated instead of going strait to breaking changes.
|
This can result in slightly odd-looking code. Is this how we expect clients to use the new API? // Set the content on the VC
highlightController.titleText = @"Look, a New Feature!";
highlightController.bodyText = @"Look at this great new feature. It's great!";
// Set the colors on the view
highlightController.featureHighlightView.titleColor = UIColor.whiteColor;
highlightController.featureHighlightView.bodyColor = UIColor.whiteColor;
highlightController.featureHighlightView.outerHighlightColor = UIColor.darkGrayColor; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose FeatureHighlightView property from FeatureHighlightViewController.
Removing Redundant properties from FeatureHighlightViewController
Internal Clean up to simplify dynamic font logic.
Updating the tests.
Close #3144