[ActivityIndicator] Update accessibility label and value #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you able to auto-generate these changes in some way, or was this a manual change? |
jverkoey
reviewed
Apr 5, 2018
|
|
||
| /* Accessibility label for activity indicator progress halted */ | ||
| "MaterialActivityIndicatorProgressHaltedAccessibilityLabel" = "Progress Halted"; | ||
| /* Accessibility value for indeterminate activity indicator in progress. */ |
There was a problem hiding this comment.
Yep! Thanks, updated
jverkoey
approved these changes
Apr 5, 2018
Codecov Report
@@ Coverage Diff @@
## develop #3261 +/- ##
===========================================
- Coverage 51.76% 51.75% -0.02%
===========================================
Files 178 178
Lines 25009 25014 +5
Branches 1196 1196
===========================================
Hits 12946 12946
- Misses 11989 11994 +5
Partials 74 74
Continue to review full report at Codecov.
|
jverkoey
changed the title
|
This ended up being a partially manual process. Generate the strings internally, manually create a PR externally. |
The generated files were created with generate_string_tables.py internally, then exported manually to the external material-components-ios repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/156527550