Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix green Slider example color #3292

Merged
merged 2 commits into from
Apr 9, 2018
Merged

[Slider] Fix green Slider example color #3292

merged 2 commits into from
Apr 9, 2018

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Apr 9, 2018

The "Green slider without hollow circle at 0" was not green.

Before
green-slider-before

After
green-slider-after

The "Green slider without hollow circle at 0" was not green.
@romoore romoore requested a review from a team April 9, 2018 14:50
@codecov-io
Copy link

Codecov Report

Merging #3292 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3292      +/-   ##
===========================================
+ Coverage    52.58%   52.65%   +0.07%     
===========================================
  Files          180      183       +3     
  Lines        25006    25215     +209     
  Branches      1204     1211       +7     
===========================================
+ Hits         13149    13278     +129     
- Misses       11783    11862      +79     
- Partials        74       75       +1
Impacted Files Coverage Δ
...nBar/src/ColorThemer/MDCNavigationBarColorThemer.m 100% <0%> (ø) ⬆️
...ents/schemes/Color/src/MDCLegacyTonalColorScheme.m 0% <0%> (ø)
...mponents/schemes/Color/src/MDCLegacyTonalPalette.m 72.34% <0%> (ø)
...omponents/schemes/Color/src/MDCLegacyColorScheme.m 55.93% <0%> (ø)
components/NavigationBar/src/MDCNavigationBar.m 83.33% <0%> (+0.84%) ⬆️
components/Dialogs/src/MDCAlertController.m 39.05% <0%> (+12.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e2935...5c8cd2a. Read the comment docs.

@romoore romoore merged commit 2b37db4 into material-components:develop Apr 9, 2018
@romoore romoore deleted the slider-example branch April 9, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants