Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextFields] fixing color mapping for floatingNormal and floatingActive Colors. #3617

Conversation

mohammadcazig
Copy link
Contributor

@mohammadcazig mohammadcazig commented May 1, 2018

Both Floating active and normal color should be set in color scheme.

Before:
screen shot 2018-05-02 at 11 16 06 am
screen shot 2018-05-02 at 11 16 23 am

After:
screen shot 2018-05-02 at 11 14 31 am
screen shot 2018-05-02 at 11 14 46 am

Copy link
Contributor

@randallli randallli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect unit tests covering this

@ianegordon
Copy link
Contributor

Please add a before / after screenshot.

@ianegordon ianegordon added the kokoro:force-run Restart the kokoro jobs for this PR. label May 2, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Restart the kokoro jobs for this PR. label May 2, 2018
@ianegordon ianegordon merged commit 7e3c5ae into material-components:develop May 2, 2018
@codecov-io
Copy link

Codecov Report

Merging #3617 into develop will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3617      +/-   ##
===========================================
- Coverage    54.79%   54.78%   -0.01%     
===========================================
  Files          320      320              
  Lines        27303    27305       +2     
===========================================
  Hits         14960    14960              
- Misses       12343    12345       +2
Impacted Files Coverage Δ
...ds/src/ColorThemer/MDCFilledTextFieldColorThemer.m 0% <0%> (ø) ⬆️
.../src/ColorThemer/MDCOutlinedTextFieldColorThemer.m 0% <0%> (ø) ⬆️
...xtFields/src/ColorThemer/MDCTextFieldColorThemer.m 75.4% <100%> (+0.4%) ⬆️
components/TextFields/src/MDCTextField.m 77.97% <0%> (-1.78%) ⬇️
components/ProgressView/src/MDCProgressView.m 43.19% <0%> (-1.19%) ⬇️
components/Slider/src/MDCSlider.m 78.54% <0%> (-0.34%) ⬇️
components/Chips/src/MDCChipField.m 16.62% <0%> (-0.27%) ⬇️
...onents/TextFields/src/MDCTextInputControllerBase.m 89.6% <0%> (-0.1%) ⬇️
components/private/ThumbTrack/src/MDCThumbTrack.m 60.52% <0%> (+0.39%) ⬆️
...PageControl/src/private/MDCPageControlTrackLayer.m 39.26% <0%> (+1.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e403d...9fa9978. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants