Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureHighlight] title not attributed. #4175

Conversation

mohammadcazig
Copy link
Contributor

Rookie mistake in the code. Feature Highlight Title was never set as attributed.

@codecov-io
Copy link

Codecov Report

Merging #4175 into develop will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4175      +/-   ##
===========================================
- Coverage    55.12%   54.94%   -0.18%     
===========================================
  Files          320      320              
  Lines        27378    27376       -2     
===========================================
- Hits         15092    15042      -50     
- Misses       12286    12334      +48
Impacted Files Coverage Δ
...eHighlight/src/MDCFeatureHighlightViewController.m 35.5% <0%> (ø) ⬆️
...ponents/ButtonBar/src/private/MDCButtonBarButton.m 93.33% <0%> (-6.67%) ⬇️
components/TextFields/src/MDCTextField.m 77.97% <0%> (-3.8%) ⬇️
...ents/Snackbar/src/private/MDCSnackbarOverlayView.m 61.07% <0%> (-2.8%) ⬇️
components/ButtonBar/src/MDCButtonBar.m 56.88% <0%> (-1.82%) ⬇️
components/NavigationBar/src/MDCNavigationBar.h 90% <0%> (-0.91%) ⬇️
components/Ink/src/private/MDCLegacyInkLayer.m 36.91% <0%> (-0.74%) ⬇️
components/Snackbar/src/MDCSnackbarMessageView.m 50.77% <0%> (-0.71%) ⬇️
...exibleHeader/src/MDCFlexibleHeaderViewController.m 70.44% <0%> (-0.63%) ⬇️
components/Tabs/src/private/MDCItemBar.m 42.75% <0%> (-0.52%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b919e...8bd588f. Read the comment docs.

@ianegordon
Copy link
Contributor

:/ How is this not a warning?

@ianegordon ianegordon merged commit 5ed1f44 into material-components:develop May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants