[TextFields] {BreakingChange} Remove unused backgroundColor property
#4452
Conversation
Only MDCTextInputControllerFullWidth is using `backgroundColor` in any meaningful way. For MDCTextInputControllerBase, the property wasn't used anywhere in the input controller.
|
Based on the changes, the title has been prefixed with [TextFields]. |
romoore
changed the title
backgroundColor property
romoore
changed the title
backgroundColor propertybackgroundColor property
API diff detected the following changesTextFieldsMDCTextInputControllerFullWidthnew property: new property: MDCTextInputControllerBaseremoved property: MDCTextInputControllerremoved property: removed property: |
romoore
changed the title
backgroundColor propertybackgroundColor property
There was a problem hiding this comment.
This LGTM I suppose! @romoore, is there something we need to do when there's a breaking change? I forget...
|
These properties had no effect outside of the FullWidth controller. I suppose we could mark them deprecated THIS release and then delete them NEXT release? @ianegordon or @randallli might be able to weigh-in here. |
|
I believe this should just go thru without a deprecation. It was dead code in the other styles and isn't leaving the one that's using it. Just making it less public. |
|
Adding @yarneo as the next release cop. |
Only MDCTextInputControllerFullWidth is using
backgroundColorin anymeaningful way. For MDCTextInputControllerBase, the property wasn't used
anywhere in the input controller.
Reduces the scope of #3357