Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Fix bug where initialization of nav controller with root view controller would not inject an App Bar. #4691

Merged
merged 1 commit into from Aug 3, 2018

Conversation

jverkoey
Copy link
Contributor

@jverkoey jverkoey commented Aug 2, 2018

Verified that the added test fails prior to this change and succeeds after.

Closes https://github.com/material-components/material-components-ios/issues/4688

…nav controller would not be injected with an App Bar.

Verified that the added test fails prior to this change and succeeds after.

Closes https://github.com/material-components/material-components-ios/issues/4688
@jverkoey jverkoey requested a review from a team August 2, 2018 14:09
@codecov-io
Copy link

Codecov Report

Merging #4691 into develop will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4691      +/-   ##
===========================================
- Coverage    53.55%   53.36%   -0.19%     
===========================================
  Files          323      323              
  Lines        27921    27899      -22     
===========================================
- Hits         14952    14888      -64     
- Misses       12969    13011      +42
Impacted Files Coverage Δ
...ponents/AppBar/src/MDCAppBarNavigationController.m 87.25% <100%> (+5.81%) ⬆️
...exibleHeader/src/MDCFlexibleHeaderViewController.m 63.15% <0%> (-9.15%) ⬇️
...ponents/ButtonBar/src/private/MDCButtonBarButton.m 93.33% <0%> (-6.67%) ⬇️
components/TextFields/src/MDCTextField.m 74.11% <0%> (-3.32%) ⬇️
components/NavigationBar/src/MDCNavigationBar.h 70% <0%> (-2.73%) ⬇️
components/ButtonBar/src/MDCButtonBar.m 64.49% <0%> (-1.82%) ⬇️
components/Tabs/src/private/MDCItemBar.m 42.75% <0%> (-0.52%) ⬇️
components/Typography/src/MDCTypography.m 91.07% <0%> (-0.47%) ⬇️
components/TextFields/src/MDCMultilineTextField.m 76.62% <0%> (-0.44%) ⬇️
components/Chips/src/MDCChipField.m 16.62% <0%> (-0.27%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acde0b...ea5c3c5. Read the comment docs.

@jverkoey jverkoey changed the title [AppBar] Fix bug where root view controller during initialization of nav controller would not be injected with an App Bar. [AppBar] Fix bug where initialization of nav controller with root view controller during would not be injected with an App Bar. Aug 2, 2018
@jverkoey jverkoey changed the title [AppBar] Fix bug where initialization of nav controller with root view controller during would not be injected with an App Bar. [AppBar] Fix bug where initialization of nav controller with root view controller during not inject an App Bar. Aug 2, 2018
@jverkoey jverkoey changed the title [AppBar] Fix bug where initialization of nav controller with root view controller during not inject an App Bar. [AppBar] Fix bug where initialization of nav controller with root view controller would not inject an App Bar. Aug 2, 2018
@jverkoey jverkoey merged commit ade5b5d into material-components:develop Aug 3, 2018
@jverkoey jverkoey deleted the navroot branch August 3, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants