Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Mark MDCAppBarTextColorAccessibilityMutator as deprecated. #4807

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

jverkoey
Copy link
Contributor

@jverkoey jverkoey requested a review from a team August 15, 2018 20:07
@material-automation
Copy link

API diff detected the following changes

AppBar

MDCAppBarTextColorAccessibilityMutator

removed class: MDCAppBarTextColorAccessibilityMutator

removed method: -mutate: in MDCAppBarTextColorAccessibilityMutator

@jverkoey
Copy link
Contributor Author

API diff tool is incorrectly picking up the deprecated APIs as being removed. Will investigate separately.

@codecov-io
Copy link

Codecov Report

Merging #4807 into develop will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4807      +/-   ##
===========================================
- Coverage    53.93%   53.58%   -0.35%     
===========================================
  Files          324      324              
  Lines        28076    28074       -2     
===========================================
- Hits         15143    15044      -99     
- Misses       12933    13030      +97
Impacted Files Coverage Δ
components/AppBar/src/MDCAppBarViewController.h 33.33% <ø> (ø) ⬆️
components/AppBar/src/MDCAppBarViewController.m 56.81% <ø> (ø) ⬆️
...exibleHeader/src/MDCFlexibleHeaderViewController.m 64.41% <0%> (-8.58%) ⬇️
...ponents/ButtonBar/src/private/MDCButtonBarButton.m 93.33% <0%> (-6.67%) ⬇️
...vigation/src/private/MDCBottomNavigationItemView.m 69.96% <0%> (-4.95%) ⬇️
...ents/BottomNavigation/src/MDCBottomNavigationBar.m 62.59% <0%> (-4.16%) ⬇️
components/TextFields/src/MDCTextField.m 74.11% <0%> (-3.32%) ⬇️
components/NavigationBar/src/MDCNavigationBar.h 70% <0%> (-2.73%) ⬇️
components/ButtonBar/src/MDCButtonBar.m 64.49% <0%> (-1.82%) ⬇️
components/Tabs/src/private/MDCItemBar.m 42.75% <0%> (-0.52%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3804902...a87b354. Read the comment docs.

@jverkoey jverkoey merged commit 8c394dc into material-components:develop Aug 17, 2018
@jverkoey jverkoey deleted the deprecate5 branch August 17, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants