[ActionSheet] Labels use text color instead of alpha #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jverkoey
approved these changes
Sep 17, 2018
|
Are there tests for the default color values? Consider adding if not. |
codeman7
changed the title
|
|
||
| - (void)setUp { | ||
| [super setUp]; | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. |
There was a problem hiding this comment.
clang-format suggested the following change:
- [super setUp];
- // Put setup code here. This method is called before the invocation of each test method in the class.
+ [super setUp];
+ // Put setup code here. This method is called before the invocation of each test method in the
+ // class.
codeman7
added a commit
that referenced
this pull request
Sep 18, 2018
Previously header labels were `ivars` and this makes them properties, which should allow for easier testing. This change is related to #5039 and #5142
codeman7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all labels used
.alphaproperty and now they use.textColor.Related to #4903