[TextFields] Invalidate caret timers in snapshot tests. #6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text fields snapshot tests were taking longer and longer to execute. The root
cause was "caret blink" timers added to the main run loop for every text field
that was set to `isEditing = YES`. It is sufficient to remove all subviews of
the text field from their superviews to invalidate the timer. The actual
culprit appears to be a private subview of class `UITextSelectionView`, but
since accessing it would be more fragile than this solution, it's best to just
destroy the view hierarchy.
Closes #6181
romoore
added
type:Internal cleanup
wenyuzhang666
approved these changes
Jan 4, 2019
|
I can't say that I understand the reasoning exactly, but i believe that the objects aren't being deallocated immediately because of some weak references hanging around. In an actual product (like the Catalog), the objects are deallocated pretty quickly (when the VC deallocates), so I suspect this is a symptom of the way XCTestCase is handled. We spoke offline and this approach is easier to understand (from a coding perspective), doesn't rely on significant knowledge of UITextField internals, and was more performant (by about 15%) than invalidating the timers directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text fields snapshot tests were taking longer and longer to execute. The root
cause was "caret blink" timers added to the main run loop for every text field
that was set to
isEditing = YES. It is sufficient to remove all subviews ofthe text field from their superviews to invalidate the timer. The actual
culprit appears to be a private subview of class
UITextSelectionView, butsince accessing it would be more fragile than this solution, it's best to just
destroy the view hierarchy.
Execution time with this change
Closes #6181