[Buttons] Add states snapshot tests. #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple snapshot tests for the main UIControlStates.
|
This PR affects multiple components. |
|
bazel detected changes to the following targets: |
|
This PR affects multiple components. |
jverkoey
approved these changes
Feb 19, 2019
galiak11
added a commit
to galiak11/material-components-ios
that referenced
this pull request
Feb 19, 2019
commit 4161262 Author: Robert Moore <rsmoore@google.com> Date: Tue Feb 19 11:09:49 2019 -0500 [Buttons] Add states snapshot tests. (material-components#6639) Simple snapshot tests for the main UIControlStates. commit 65426c8 Author: Robert Moore <rsmoore@google.com> Date: Tue Feb 19 09:26:53 2019 -0500 [Slider] Add basic snapshot tests. (material-components#6640) Adding a few snapshot tests to capture the basic styling/appearance of Sliders. commit d77f1b3 Author: Robert Moore <rsmoore@google.com> Date: Tue Feb 19 09:26:25 2019 -0500 [Dialogs] Add snapshot tests to MDCAlertController (material-components#6641) Adds basic snapshot tests to MDCAlertController. Helped identify #6637 commit fb8190d Author: Robert Moore <rsmoore@google.com> Date: Tue Feb 19 09:25:57 2019 -0500 [BottomAppBar] Add basic snapshot tests. (material-components#6643) Adding a few simple snapshot tests to capture the default appearance of the bar. commit ecf420e Author: Robert Moore <rsmoore@google.com> Date: Tue Feb 19 08:36:30 2019 -0500 [BottomAppBar] Fix FAB location when RTL changes. (material-components#6644) If the `semanticContentAttribute` for an MDCBottomAppBarView changes during its lifetime, it won't correctly reposition the FAB. Instead of checking the interface layout orientation once during initialization, it should check every time it needs to perform layout. |Before|After| |---|---| |<img width="380" alt="testfloatingbuttontrailingrtl_11_2-develop" src="https://user-images.githubusercontent.com/1753199/52929433-6812c800-3312-11e9-8505-07933e1ee077.png">|<img width="380" alt="testfloatingbuttontrailingrtl_11_2 2x" src="https://user-images.githubusercontent.com/1753199/52929438-6ba64f00-3312-11e9-805f-edc2e68cf1a5.png">| Fixes #6642 commit 6090cd6 Author: Wenyu Zhang <8836258+wenyuzhang666@users.noreply.github.com> Date: Fri Feb 15 16:03:36 2019 -0500 [MDC Dialogs] add an example for custom dialog view controller themed by theming extension (material-components#6601) commit abec164 Author: Yarden Eitan <yar@google.com> Date: Fri Feb 15 15:12:14 2019 -0500 add a11y identifier for the nav drawer scrollview (material-components#6629) Clients have requested access to the internal scrollview for EarlGrey testing by providing an accessibility identifier to the scrollview. commit 7b73a03 Merge: 3b1d82a c79f7cc Author: Randall Li <randallli@google.com> Date: Fri Feb 15 00:18:41 2019 -0500 Merge branch 'release-candidate' into develop commit c79f7cc Author: Randall Li <randallli@google.com> Date: Thu Feb 14 13:47:08 2019 -0500 fixed changlog manually based on feedback commit e744b01 Merge: 100416a 155f278 Author: Randall Li <randallli@google.com> Date: Thu Feb 14 13:01:59 2019 -0500 Merge branch 'stable' into release-candidate commit 100416a Author: Randall Li <randallli@google.com> Date: Wed Feb 13 16:32:07 2019 -0500 manual copyedit of the changelog commit 85d3f99 Author: Randall Li <randallli@google.com> Date: Wed Feb 13 13:38:03 2019 -0500 Bumped version number to 77.0.0. commit c786698 Author: Randall Li <randallli@google.com> Date: Wed Feb 13 13:36:44 2019 -0500 Hand-modified CHANGELOG.md API diff. commit eabf0e0 Author: Randall Li <randallli@google.com> Date: Wed Feb 13 12:24:15 2019 -0500 Automatic changelog preparation for release. commit 155f278 Merge: c77a2f8 0cf6486 Author: Ian Gordon <iangordon@google.com> Date: Fri Feb 8 17:08:25 2019 -0500 Merge branch 'release-candidate' into stable
![https://user-images.githubusercontent.com/1753199/52929433-6812c800-3312-11e9-8505-07933e1ee077.png">|<img](https://user-images.githubusercontent.com/1753199/52929433-6812c800-3312-11e9-8505-07933e1ee077.png">|<img){kind=link}
![https://user-images.githubusercontent.com/1753199/52929438-6ba64f00-3312-11e9-805f-edc2e68cf1a5.png">|](https://user-images.githubusercontent.com/1753199/52929438-6ba64f00-3312-11e9-805f-edc2e68cf1a5.png">|){kind=link}
codeman7
added a commit
that referenced
this pull request
Apr 9, 2019
## Context As of #7087 [`MDCButton`](https://github.com/material-components/material-components-ios/tree/develop/components/Buttons) now supports [`MDCStatefulRipple`](https://github.com/material-components/material-components-ios/blob/develop/components/Ripple/src/MDCStatefulRippleView.h). This PR adds snapshot test when this behavior is enabled. This PR is a _copy_ of #6639 with a few minor modifications. ## Alternatives considered 1. Adding [EarlGrey](https://github.com/google/EarlGrey) tests. We currently don't have any earl grey test so this would be a bigger discussion with the team. 2. Mocking `UITouch` events, and calling `touchesBegan`, `touchesEnded`, `touchedCancelled`, and `touchesMoved`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple snapshot tests for the main UIControlStates.