[List] Add basic snapshot tests for MDCSelfSizingStereoCell. #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyuzhang666
requested review from
galiak11
and removed request for
andrewoverton
| self.cell.leadingImageView.image = [UIImage mdc_testImageOfSize:CGSizeMake(24, 24) | ||
| withStyle:MDCSnapshotTestImageStyleCheckerboard]; | ||
| self.cell.trailingImageView.image = [UIImage mdc_testImageOfSize:CGSizeMake(24, 24) | ||
| withStyle:MDCSnapshotTestImageStyleRectangles]; |
There was a problem hiding this comment.
clang-format suggested the following change:
- self.cell.leadingImageView.image = [UIImage mdc_testImageOfSize:CGSizeMake(24, 24)
- withStyle:MDCSnapshotTestImageStyleCheckerboard];
- self.cell.trailingImageView.image = [UIImage mdc_testImageOfSize:CGSizeMake(24, 24)
- withStyle:MDCSnapshotTestImageStyleRectangles];
+ self.cell.leadingImageView.image =
+ [UIImage mdc_testImageOfSize:CGSizeMake(24, 24)
+ withStyle:MDCSnapshotTestImageStyleCheckerboard];
+ self.cell.trailingImageView.image =
+ [UIImage mdc_testImageOfSize:CGSizeMake(24, 24)
+ withStyle:MDCSnapshotTestImageStyleRectangles];
|
bazel detected changes to the following targets: |
romoore
approved these changes
May 22, 2019
| [self snapshotVerifyView:snapshotView]; | ||
| } | ||
|
|
||
| - (void)speedAllLayersOfView:(UIView *)view { |
There was a problem hiding this comment.
Looks like this is no longer used - can it be removed?
There was a problem hiding this comment.
Thanks for catching it. Addressed in c9bb6ef.
jverkoey
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-work for https://github.com/material-components/material-components-ios/issues/7385.