Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Update README for MDCTabBarView. #7673

Merged
merged 2 commits into from Jun 21, 2019
Merged

[Tabs] Update README for MDCTabBarView. #7673

merged 2 commits into from Jun 21, 2019
+106 −0

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Jun 21, 2019

Adds a small section about MDCTabBarView so it can be updated over time as
changes are made.

Closes #7672

[Tabs] Update README for MDCTabBarView.
bbbc9dc 
Adds a small section about MDCTabBarView so it can be updated over time as
changes are made.

Closes #7672
@romoore romoore added type:Documentation Documentation or example code must be written. [Tabs] labels Jun 21, 2019
@romoore romoore requested review from galiak11, mikefan1991, leonmz and a team June 21, 2019 15:26
jverkoey
jverkoey approved these changes Jun 21, 2019
View reviewed changes
components/Tabs/docs/tabbarview.md Outdated
let tabBarView = MDCTabBarView()
addSubview(tabBarView)

configureTabBarViewConstraints()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a reader this method looks like something that might be part of the public API, but it looks like it's a placeholder for constraints logic. Can this be a comment instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@romoore romoore merged commit 2dea42f into material-components:develop Jun 21, 2019
@romoore romoore deleted the tabs-readme branch June 21, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jverkoey jverkoey jverkoey approved these changes

@galiak11 galiak11 Awaiting requested review from galiak11

@mikefan1991 mikefan1991 Awaiting requested review from mikefan1991

@leonmz leonmz Awaiting requested review from leonmz

Assignees
No one assigned
Labels
cla: yes [Tabs] type:Documentation Documentation or example code must be written.
Projects
None yet
Milestone
No milestone
3 participants
@romoore @googlebot @jverkoey