Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Vertically hug content in sizeThatFits: #7777

Merged
merged 1 commit into from Jul 2, 2019
Merged

[Tabs] Vertically hug content in sizeThatFits: #7777

merged 1 commit into from Jul 2, 2019

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Jul 2, 2019

To ensure that TabBarView works correctly with the Flexible Header, it should
"hug" its content vertically when interrogated for a fit size. The previous
behavior may have resulted in a tab bar that was too tall (or too short).

Closes #7769

[Tabs] Vertically hug content in sizeThatFits:
c8aa5cf 
To ensure that TabBarView works correctly with the Flexible Header, it should
"hug" its content vertically when interrogated for a fit size. The previous
behavior may have resulted in a tab bar that was too tall (or too short).

Closes #7769
@romoore romoore added the [Tabs] label Jul 2, 2019
@material-automation
Copy link

bazel detected changes to the following targets:

//components/Tabs:ObjcExamples
//components/Tabs:TabBarView
//components/Tabs:snapshot_test_lib
//components/Tabs:snapshot_tests
//components/Tabs:snapshot_tests.swift_runtime_linkopts
//components/Tabs:snapshot_tests_test_binary
//components/Tabs:snapshot_tests_test_bundle
//components/Tabs:unit_test_tabbarview_sources
//components/Tabs:unit_tests
//components/Tabs:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/Tabs:unit_tests_IPAD_PRO_12_9_IN_9_3.swift_runtime_linkopts
//components/Tabs:unit_tests_IPAD_PRO_12_9_IN_9_3_test_binary
//components/Tabs:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/Tabs:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/Tabs:unit_tests_IPHONE_7_PLUS_IN_10_3.swift_runtime_linkopts
//components/Tabs:unit_tests_IPHONE_7_PLUS_IN_10_3_test_binary
//components/Tabs:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/Tabs:unit_tests_IPHONE_X_IN_11_0
//components/Tabs:unit_tests_IPHONE_X_IN_11_0.swift_runtime_linkopts
//components/Tabs:unit_tests_IPHONE_X_IN_11_0_test_binary
//components/Tabs:unit_tests_IPHONE_X_IN_11_0_test_bundle

@material-automation
Copy link

bazel detected changes to the following targets:

//components/Tabs:snapshot_tests
//components/Tabs:snapshot_tests_test_bundle
//components/Tabs:unit_tests
//components/Tabs:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/Tabs:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/Tabs:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/Tabs:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/Tabs:unit_tests_IPHONE_X_IN_11_0
//components/Tabs:unit_tests_IPHONE_X_IN_11_0_test_bundle

@romoore romoore merged commit 012c11d into material-components:develop Jul 2, 2019
@romoore romoore deleted the issue-7769 branch July 2, 2019 18:29
romoore pushed a commit that referenced this pull request Jul 2, 2019
[Tabs] Vertically hug content in sizeThatFits: (#7777)
021b2f8 
To ensure that TabBarView works correctly with the Flexible Header, it should
"hug" its content vertically when interrogated for a fit size. The previous
behavior may have resulted in a tab bar that was too tall (or too short).

Closes #7769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewoverton andrewoverton andrewoverton approved these changes

@jverkoey jverkoey Awaiting requested review from jverkoey

@ajsecord ajsecord Awaiting requested review from ajsecord

@mikefan1991 mikefan1991 Awaiting requested review from mikefan1991

@leonmz leonmz Awaiting requested review from leonmz

Assignees
No one assigned
Labels
cla: yes [Tabs]
Projects
None yet
Milestone
No milestone
4 participants
@romoore @material-automation @andrewoverton @googlebot