[Tabs] Expand configuration in MDCTabBarView example. #8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds configuration options for `preferredLayoutStyle` and toggling `contentInset`. Helps exercise #8236
|
bazel detected changes to the following targets: |
codeman7
approved these changes
Sep 25, 2019
romoore
pushed a commit
that referenced
this pull request
Sep 25, 2019
Some icon images were not being tested. Adds those missing tests. Found while working on #8498
romoore
pushed a commit
that referenced
this pull request
Sep 25, 2019
Icons were not fully integrated into the catalog project and the relevant
scripts were out of date. This PR addressed the following issues:
* The Icons source files had been hand-modified and did not match the
script outputs.
* The Icons unit tests were not included in the Catalog or Dragons
projects.
It addresses these issues through the following:
* Updates `scripts/sync_icons.sh` to:
- Match the copyright header format used by the project.
- Run clang-format on each generated source file.
- Add Icons unit tests to the MaterialComponents podspec.
- Remove duplicate import of `MaterialIcons.h` in the source
implementation files.
* Adds the Icons unit test targets to the Catalog and Dragons Xcode schemes.
Discovered while working on #8498
ggdiez
pushed a commit
to solidgear/material-components-ios
that referenced
this pull request
Sep 27, 2019
…nents#8498) Adds configuration options for `preferredLayoutStyle` and toggling `contentInset`. |Fewer Tabs (Portrait)|More Tabs (Landscape)| |---|---| ||| Helps exercise #8236
||){kind=link}
ggdiez
pushed a commit
to solidgear/material-components-ios
that referenced
this pull request
Sep 27, 2019
Some icon images were not being tested. Adds those missing tests. Found while working on material-components#8498
ggdiez
pushed a commit
to solidgear/material-components-ios
that referenced
this pull request
Sep 27, 2019
) Icons were not fully integrated into the catalog project and the relevant scripts were out of date. This PR addressed the following issues: * The Icons source files had been hand-modified and did not match the script outputs. * The Icons unit tests were not included in the Catalog or Dragons projects. It addresses these issues through the following: * Updates `scripts/sync_icons.sh` to: - Match the copyright header format used by the project. - Run clang-format on each generated source file. - Add Icons unit tests to the MaterialComponents podspec. - Remove duplicate import of `MaterialIcons.h` in the source implementation files. * Adds the Icons unit test targets to the Catalog and Dragons Xcode schemes. Discovered while working on material-components#8498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration options for
preferredLayoutStyleand togglingcontentInset.Helps exercise #8236